Skip to content

fix(a11y): use rem-based width for expanded side-nav#3426

Merged
bilal-karim merged 1 commit into
mainfrom
a11y/side-nav-rem-width
May 22, 2026
Merged

fix(a11y): use rem-based width for expanded side-nav#3426
bilal-karim merged 1 commit into
mainfrom
a11y/side-nav-rem-width

Conversation

@bilal-karim
Copy link
Copy Markdown
Member

@bilal-karim bilal-karim commented May 21, 2026

Summary

  • Converts the Cloud side-nav expanded width from w-[210px] to w-[13.125rem] in navigation-container.svelte
  • Visually identical at default 16px base font size (13.125 × 16 = 210)
  • Scales with user font-size preference and browser text-only zoom, preventing nav label clipping at 200%+ zoom (WCAG 2.2 SC 1.4.4 Resize Text)

Test plan

  • Open Cloud deployment with side-nav expanded — confirm visual is identical to current
  • Firefox: View → Zoom → Zoom Text Only → 200% — confirm all nav labels remain readable without clipping
  • Verify OSS nav is unaffected (this class only applies to the isCloud branch)

🤖 Generated with Claude Code

Converts the Cloud side-nav expanded width from `w-[210px]` to
`w-[13.125rem]` (identical at default 16px base). Scales with user
font-size preference and browser text-only zoom per WCAG 2.2 SC 1.4.4.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@bilal-karim bilal-karim requested a review from a team as a code owner May 21, 2026 19:57
@vercel
Copy link
Copy Markdown

vercel Bot commented May 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment May 21, 2026 7:58pm

Request Review

@bilal-karim bilal-karim marked this pull request as ready for review May 21, 2026 20:28
@bilal-karim bilal-karim changed the title fix: use rem-based width for expanded side-nav fix(a11y): use rem-based width for expanded side-nav May 22, 2026
@bilal-karim bilal-karim merged commit 42c58c4 into main May 22, 2026
19 checks passed
@bilal-karim bilal-karim deleted the a11y/side-nav-rem-width branch May 22, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants