Fix: Enforce production secrets and remove unsafe fallbacks - #892
Open
mertcano wants to merge 1 commit into
Open
Fix: Enforce production secrets and remove unsafe fallbacks#892mertcano wants to merge 1 commit into
mertcano wants to merge 1 commit into
Conversation
This PR removes unsafe fallback behaviors for critical secrets in production, ensuring the application fails closed if environment variables are misconfigured. Updates: mppx-payment-link.server.ts: Removed the hardcoded fallback private key (0x...01). It now explicitly throws an error if FEE_PAYER_PRIVATE_KEY is missing outside of development. mppx-secret.server.ts: Dropped the lifecycleEvent === "build" condition. It no longer silently injects the local example key during production builds, throwing an error instead if MPP_SECRET_KEY is not provided.
|
@mertcano is attempting to deploy a commit to the Tempo Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes unsafe fallback behaviors for critical secrets in production, ensuring the application fails closed if environment variables are misconfigured.
Updates:
mppx-payment-link.server.ts: Removed the hardcoded fallback private key (0x...01). It now explicitly throws an error if FEE_PAYER_PRIVATE_KEY is missing outside of development.
mppx-secret.server.ts: Dropped the lifecycleEvent === "build" condition. It no longer silently injects the local example key during production builds, throwing an error instead if MPP_SECRET_KEY is not provided.