fix(session-analyzer): satisfy Rust 1.93 clippy gate - #10
Merged
Conversation
AlexMikhalev
force-pushed
the
task/3211-session-analyzer-clippy
branch
from
August 12, 2026 11:13
ce922fe to
c9cc680
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the repository-wide Rust 1.93 CI gates by applying semantics-preserving let-chain refactors to
terraphim-session-analyzer.clippy::collapsible_iffindings across library, binary, connector, and test targets;map_or(true, …)with Clippy’s equivalentis_none_orsuggestion;terraphim_updaterustfmt correction required by the workspace formatter gate.RED → GREEN evidence
Initial workspace clippy stopped after 19 library-target errors. Once those were fixed,
--all-targetsexposed ten additional pre-existing binary/test-target findings (9 collapsible-if and 1 unnecessary-map-or). All are corrected without behavior changes.Final verified gates:
cargo fmt --all -- --check: pass.cargo clippy --workspace --all-targets -- -D warnings: pass.cargo test -p terraphim-session-analyzer: pass:git diff --check: clean.Tracking
Fixes
terraphim-ai#3211and unblocks workspace CI forterraphim-clients#9.Scope
No lint
allow, dependency, version, release, grep behavior, or generated artifact changes.