Repository navigation
Fix #365: verify each lipo architecture separately in universal macOS steps - #58
Merged
Merged
Conversation
…teps
lipo from Xcode 27 rejects several architectures in a single -verify_arch
("requires exactly one input file"), which failed the release-mcp run for
terraphim_mcp_server-v1.21.18-rc.1 in "Create universal macOS binary".
Verify x86_64 and arm64 one at a time and require exactly those two slices
from `lipo -archs`, in release-mcp.yml and in release-binaries.yml (which
used the same multi-architecture form). Contract tests pin the new form and
mutation-check the old ones.
Refs terraphim/terraphim-clients#365 (Gitea)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Addresses the structural review of this PR. Refs terraphim/terraphim-clients#365 (Gitea) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Author
Structural review (pi-rust, openai-codex/gpt-5.5, structural-pr-review)No blocking findings; confidence 0.86. Both workflow fragments were judged shell-correct under
Evidence beyond the review: both workflow fragments were executed for real with this Mac's lipo against a clang-built universal binary (pass) and a thin binary (fail). CI is green on the self-hosted runner on the earlier head 38d4739 (the later commit changes only a test). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lipofrom Xcode 27 rejects several architectures in one-verify_archcall (lipo: -verify_arch requires exactly one input file), whichever side the file is on. That failed the "Create universal macOS binary" job of theterraphim_mcp_server-v1.21.18-rc.1release-mcp run (all five per-target builds passed).release-mcp.ymlandrelease-binaries.yml(same multi-architecture form increate-universal-macos) now runlipo FILE -verify_arch <arch>forx86_64andarm64separately, then requirelipo -archsto list exactly those two. The stale "Xcode 16.4" comments are replaced.test_universal_lipo_verify_arch_uses_safe_argument_ordernow pins the per-architecture form with mutations (flags-first, multi-arch, verify dropped, archs check dropped); a new release-mcp test pins the same.Refs terraphim/terraphim-clients#365 (Gitea)
Evidence
set -euo pipefail.actionlint(including shellcheck on the run scripts) clean; release contract tests pass apart from the three existing macOS-only/bin/trueerrors.🤖 Generated with Claude Code