feat(prefer-user-event-setup): add new rule #1125
Merged
+682
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforces using userEvent.setup() pattern instead of direct method calls as recommended in the official user-event documentation.
gipcompany
force-pushed
the
pr/prefer-user-event-setup-rule
branch
from
3626415 to
f89ad18
Compare
Belco90
requested review from
Belco90 and
Copilot
and removed request for
Copilot
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1125 +/- ##
==========================================
+ Coverage 97.40% 97.48% +0.07%
==========================================
Files 48 49 +1
Lines 5826 5997 +171
Branches 1477 1518 +41
==========================================
+ Hits 5675 5846 +171
Misses 149 149
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Belco90
reviewed
Dec 14, 2025
Member
Belco90
left a comment
Belco90
left a comment
There was a problem hiding this comment.
@gipcompany thanks for your contribution! Great implementation and test cases, just added some minor comments.
Signed-off-by: Atsushi Ishida <[email protected]>
Belco90
approved these changes
Dec 14, 2025
Belco90
changed the title
Belco90
requested changes
Dec 14, 2025
Contributor
Author
This was addressed with 8510411. |
Belco90
approved these changes
Dec 15, 2025
Member
|
@all-contributors please add @gipcompany for code, test, docs |
Contributor
|
I've put up a pull request to add @gipcompany! 🎉 |
|
🎉 This PR is included in version 7.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
awesome new rule. thx @gipcompany ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
Changes
Context
Closes #646