Skip to content

fix: Adjust ping requests. #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
goloroden merged 3 commits into from
Dec 3, 2024
Merged

fix: Adjust ping requests. #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbd02cd
fix: Adjust ping requests.
Renni771 Nov 26, 2024
cbcba16
fix: Use correct GitHub teams.
Renni771 Nov 27, 2024
68c344b
chore: Update ESDB docker image.
Renni771 Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/.dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ updates:
interval: weekly
open-pull-requests-limit: 10
assignees:
- thenativeweb/internal_eventsourcingdb_dep
- thenativeweb/internal_dev
labels:
- Dependencies
commit-message:
Expand All @@ -18,7 +18,7 @@ updates:
interval: weekly
open-pull-requests-limit: 10
assignees:
- thenativeweb/internal_eventsourcingdb_dep
- thenativeweb/internal_dev
labels:
- Dependencies
commit-message:
Expand All @@ -30,7 +30,7 @@ updates:
interval: "weekly"
open-pull-requests-limit: 10
assignees:
- thenativeweb/internal_eventsourcingdb_dep
- thenativeweb/internal_dev
labels:
- Dependencies
commit-message:
Expand Down
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
* @thenativeweb/internal_eventsourcingdb_rw
* @thenativeweb/internal_dev
2 changes: 1 addition & 1 deletion eventsourcingdb_client_python/handlers/ping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@


async def ping(client: AbstractBaseClient) -> None:
response = await client.http_client.get('/ping')
response = await client.http_client.get('/api/ping')
response_body = bytes.decode(await response.body.read(), encoding='utf-8')

if response.status_code != HTTPStatus.OK or response_body != HTTPStatus.OK.phrase:
Expand Down
2 changes: 1 addition & 1 deletion tests/shared/docker/eventsourcingdb/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
FROM ghcr.io/thenativeweb/eventsourcingdb:0.73.0
FROM ghcr.io/thenativeweb/eventsourcingdb:0.79.0
4 changes: 2 additions & 2 deletions tests/shared/start_local_http_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def attached_handler():

attach_handlers(attach_handler)

@self.app.get('/__python_test__/ping')
@self.app.get('/__python_test__/api/ping')
def ping():
return "OK"

Expand All @@ -48,7 +48,7 @@ async def ping_app() -> RetryResult[None]:
async with session:
try:
response = await session.get(
f'http://localhost:{local_http_server.port}/__python_test__/ping', timeout=1
f'http://localhost:{local_http_server.port}/__python_test__/api/ping', timeout=1
)
except aiohttp.ClientError as error:
return Retry(cause=error)
Expand Down
4 changes: 2 additions & 2 deletions tests/test_ping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def handle_ping(response: Response) -> Response:
response.set_data('OK')
return response

attach_handler('/ping', 'GET', handle_ping)
attach_handler('/api/ping', 'GET', handle_ping)

client = await get_client(attach_handlers)

Expand All @@ -67,7 +67,7 @@ def handle_ping(response: Response) -> Response:
response.set_data('not OK')
return response

attach_handler('/ping', 'GET', handle_ping)
attach_handler('/api/ping', 'GET', handle_ping)

client = await get_client(attach_handlers)

Expand Down