Skip to content

Fix skipping a test in test-jack-detection. #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redzynix merged 3 commits into from
Oct 24, 2025
Merged

Fix skipping a test in test-jack-detection. #1313

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f73690
test: Skip before enabling logs to avoid failure
arikgreen Oct 20, 2025
da7bcbd
test: fix checking state of a mixer device
arikgreen Oct 20, 2025
a7c0c66
test: fix skipping: test jack detection
arikgreen Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test-case/test-jack-detection-playback-capture.sh
View file
Open in desktop
Copy link
Copy Markdown
Collaborator

@marc-hb marc-hb Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit subject and message are quite vague. You could be more specific, something like: "Skip before enabling logs to avoid failure".

Also: why does the moved line fail?

Copy link
Copy Markdown
Contributor Author

@arikgreen arikgreen Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because in this case the log is empty, and an error is raised:
[ERROR] Empty logfile

commit msg - I'll change

Copy link
Copy Markdown
Collaborator

@marc-hb marc-hb Oct 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because in this case the log is empty, and an error is raised:
[ERROR] Empty logfile

This is still not clear; there are multiple tests that do that in the same order and they never failed like this.

git grep -e skip_test -e start_log_

test-case/volume-basic-test.sh
test-case/multiple-pause-resume.sh
test-case/test-jack-detection-playback-capture.sh
test-case/test-mic-privacy.sh

Copy link
Copy Markdown
Collaborator

@marc-hb marc-hb Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think this commit is just hiding another, unknown issue.

Copy link
Copy Markdown
Contributor Author

@arikgreen arikgreen Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark this is not the same case. For example volume-basic-test.sh
Between a logger_disabled and first appearance of skip_test there are many of commands generate logs to log file.

start_test

[[ -z $tplg ]] && die "Missing tplg file needed to run"
func_pipeline_export "$tplg" "type:playback"
logger_disabled || func_lib_start_log_collect

[[ $PIPELINE_COUNT -eq 0 ]] && die "Missing playback pipeline for aplay to run"

initialize_audio_params "0"
# play into background, this will wake up DSP and IPC. Need to clean after the test
aplay_opts -D "$dev" -c "$channel" -r "$rate" -f "$fmts" /dev/zero &
sleep 1
check_alsa_tool_process
sofcard=${SOFCARD:-0}

# https://mywiki.wooledge.org/BashFAQ/024 why cant I pipe data to read?
readarray -t pgalist < <("$TOPDIR"/tools/topo_vol_kcontrols.py "$tplg")

# This (1) provides some logging (2) avoids skip_test if amixer fails
get_sof_controls "$sofcard"
dlogi "pgalist number = ${#pgalist[@]}"
[[ ${#pgalist[@]} -ne 0 ]] || skip_test "No PGA control is available"

Original file line number Diff line number Diff line change
Expand Up @@ -171,14 +171,14 @@ main()

start_test

logger_disabled || func_lib_start_log_collect

# Check if usbrelay tool is installed
dlogi "Checking usbrelay availability..."
command -v usbrelay || {
# If usbrelay package is not installed
skip_test "usbrelay command not found. Please install usbrelay package."
}

logger_disabled || func_lib_start_log_collect

# display current status of relays
usbrelay --debug

Expand Down