audio: mixin_mixout: fix build when XRUN reporting is disabled#10645
Merged
lgirdwood merged 1 commit intothesofproject:mainfrom Mar 24, 2026
Merged
audio: mixin_mixout: fix build when XRUN reporting is disabled#10645lgirdwood merged 1 commit intothesofproject:mainfrom
lgirdwood merged 1 commit intothesofproject:mainfrom
Conversation
Build fails with CONFIG_XRUN_NOTIFICATIONS_ENABLE=n due to invalid access to "md->eos_delay_configured". Fix the build error by proper ifdefs. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
abonislawski,
Copilot,
lyakh,
softwarecki and
wjablon1
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a build failure in the mixin_mixout audio module when XRUN notifications are disabled (CONFIG_XRUN_NOTIFICATIONS_ENABLE=n) by preventing access to a conditionally compiled struct field.
Changes:
- Wrap initialization of
md->eos_delay_configuredinmixin_prepare()with#if CONFIG_XRUN_NOTIFICATIONS_ENABLE.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
softwarecki
approved these changes
Mar 23, 2026
abonislawski
approved these changes
Mar 23, 2026
lgirdwood
approved these changes
Mar 23, 2026
wjablon1
approved these changes
Mar 24, 2026
lyakh
approved these changes
Mar 24, 2026
lgirdwood
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build fails with CONFIG_XRUN_NOTIFICATIONS_ENABLE=n due to invalid access to "md->eos_delay_configured". Fix the build error by proper ifdefs.