Skip to content

app: prj.conf: use trigger threshold of 1 as default #10647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kv2019i wants to merge 1 commit into
base: main
Choose a base branch
from
Open

app: prj.conf: use trigger threshold of 1 as default #10647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions app/prj.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,9 @@ CONFIG_LOG=y
CONFIG_LOG_PRINTK=y
# Log processing is offloaded to a low-priority thread.
CONFIG_LOG_MODE_DEFERRED=y
# Wake the low-priority log thread every 100ms and/or
# if more than 5 messages are queued by the frontend.
CONFIG_LOG_PROCESS_TRIGGER_THRESHOLD=5
CONFIG_LOG_PROCESS_THREAD_SLEEP_MS=100
# Wake the low-priority log thread every time new log
# messages are available
Comment on lines +23 to +24
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammar/style: consider making this a complete sentence (e.g., add a period and/or keep it on one line). Current wording/line break reads a bit awkwardly in the config comment.

Suggested change
# Wake the low-priority log thread every time new log
# messages are available
# Wake the low-priority log thread every time new log messages are available.

Copilot uses AI. Check for mistakes.
CONFIG_LOG_PROCESS_TRIGGER_THRESHOLD=1
# Frontend buffer must be large enough to cover all
# typical bursts of log messages.
CONFIG_LOG_BUFFER_SIZE=4096
Expand Down
Loading