github: workflows: remove zmain build test#10662
github: workflows: remove zmain build test#10662lgirdwood merged 1 commit intothesofproject:mainfrom
Conversation
lgirdwood
changed the title
There was a problem hiding this comment.
Pull request overview
This PR removes the zmain Zephyr build variant from the Zephyr GitHub Actions workflow to reduce CI noise.
Changes:
- Removed
zmainfrom thezephyr_revisionmatrix in the Linux build job. - Deleted the
zmain-specific manifest override generation andwest updatelogic, leaving only themnfstpath.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/zephyr.yml
Outdated
| @@ -113,7 +113,6 @@ jobs: | |||
| # Search "zephyr_revision" and see below what they expand to. | |||
| zephyr_revision: [ | |||
| mnfst, # special value: don't override sof/west.yml | |||
There was a problem hiding this comment.
In the zephyr_revision flow sequence, mnfst still has a trailing comma after removing zmain. YAML flow sequences are typically strict about trailing commas, and this can cause the workflow to fail to parse. Remove the trailing comma (or switch to block-style list) now that there's only one entry.
| mnfst, # special value: don't override sof/west.yml | |
| mnfst # special value: don't override sof/west.yml |
.github/workflows/zephyr.yml
Outdated
| echo 'Unknown matrix.zephyr_revision'; exit 1 | ||
| fi |
There was a problem hiding this comment.
After removing the zmain option, there is still a comment later in this job that says "especially in the "zmain" case". Please update/remove that stale reference so the workflow documentation matches the supported zephyr_revision values.
There was a problem hiding this comment.
Removed the stale comment!
tmleman
left a comment
tmleman
left a comment
There was a problem hiding this comment.
This is a bad approach. You're removing a valid compatibility check that detects Zephyr main breakage early, without replacing it with anything. The "noise" is actually useful information.
Better solution:
- Create a separate scheduled workflow that runs zmain builds 1-2x daily (use cron)
- Add workflow_dispatch for manual triggering
- Add status badge to README
- Then remove zmain from PR/push CI
This keeps PR results clean while maintaining early warning capability. The daily-tests.yml workflow already shows the pattern.
Its only valid if someone owns and takes action and fixes, otherwise its noise in the PR results that have zero in common with the PR.
I don't mind adding this, although it may not be in that order/cadence. |
|
I've implemented the requested standalone scheduled workflow for |
lgirdwood
requested review from
kv2019i,
lbetlej,
mmaka1 and
plbossart
as code owners
Thank you. Fix style issue in yml file and it would be good for me: https://github.com/thesofproject/sof/actions/runs/23744040146/job/69167935104?pr=10662 |
Removes the zmain build from the PR/push matrix to reduce noise. Instead, it adds a separate `zephyr-main.yml` workflow running on a schedule to maintain early-warning capability. It also parameterizes `zephyr.yml` to be cleanly callable, and updates the README with the new status badge.
|
Fixed the |
This just adds more noise than signal to the CI results.