Use optional chaining instead of non-null assert#82
Open
johnsonsu wants to merge 3 commits intothmsgbrt:masterfrom
Open
Use optional chaining instead of non-null assert#82johnsonsu wants to merge 3 commits intothmsgbrt:masterfrom
johnsonsu wants to merge 3 commits intothmsgbrt:masterfrom
Conversation
|
@thmsgbrt Can you appreciate this branch? It's an important fix. |
|
When will this be merged? It's indeed an important fix as we get a lot of such errors in our application. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #81
Due to events like
onScrollthat this library listens to are not synchronous, they can be fired right after the component is already unmounted, causingref.currentto benull. This PR fixes the issue by using optional chaining instead of non-null assertion onref.currentusages.