fix(form): Display hint for has_one nested fields#2735
Open
mizoR wants to merge 1 commit intothoughtbot:mainfrom
Open
fix(form): Display hint for has_one nested fields#2735mizoR wants to merge 1 commit intothoughtbot:mainfrom
mizoR wants to merge 1 commit intothoughtbot:mainfrom
Conversation
Previously, hints were not displayed for has_one nested fields in forms. This fix ensures that hints are properly shown for nested fields as well.
Member
nickcharlton
left a comment
There was a problem hiding this comment.
Can you also add a reference to field hints to the documentation?
| describe "fields/has_one/_form", type: :view do | ||
| it "displays the resource name" do | ||
| has_one = instance_double( | ||
| let!(:has_one) { |
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thank you for maintaining this useful gem.
What I'm having trouble with
In my use case, certain fields are used only as nested fields. However, the field_hints feature in administrate does not work for nested fields, making it impossible to add hints for these fields. This limitation impacts usability, as users cannot see helpful hints for nested fields to understand their purpose or usage.
What I changed in this PR
Extend the functionality of field_hints to work with nested fields as well. With this change, hints can be displayed for nested fields, improving the consistency and usability of the UI.
Output sample
Thank you for reviewing this pull request.