Skip to content

Update ts-embed.ts - #649

Open
sastaachar wants to merge 2 commits into
mainfrom
sastaachar-patch-6
Open

Update ts-embed.ts#649
sastaachar wants to merge 2 commits into
mainfrom
sastaachar-patch-6

Conversation

@sastaachar

Copy link
Copy Markdown
Contributor

No description provided.

@sastaachar
sastaachar requested a review from a team as a code owner September 2, 2026 07:57

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an alert statement inside the render method of TsEmbed. The review feedback correctly identifies this as a disruptive debugging statement that should be removed before merging.

Comment thread src/embed/ts-embed.ts Outdated
* @param args
*/
public async render(): Promise<TsEmbed> {
alert("hiiiii");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This alert() call appears to be a debugging statement that was accidentally left in the code. It creates a blocking dialog in the user's browser, which is disruptive and should be removed before merging.

@pkg-pr-new

pkg-pr-new Bot commented Sep 2, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@649

commit: 3d91d00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant