[SCAL-324920] added embedd flag for answer verification - #655
Open
amal-sr-thoughtspot wants to merge 3 commits into
Open
[SCAL-324920] added embedd flag for answer verification#655amal-sr-thoughtspot wants to merge 3 commits into
amal-sr-thoughtspot wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the showSpotterVerificationButton configuration option to SpotterEmbedViewConfig, allowing users to toggle the visibility of the answer-verification button on Spotter answers. It includes corresponding URL parameter mapping and unit tests. For feedback, the JSDoc comment for showSpotterVerificationButton should be updated: the @version tag must map SDK: 1.53.0 to ThoughtSpot Cloud: 26.10.0.cl to adhere to the canonical version mapping sequence, and the description should be capitalized as showSpotterVerificationButton: Show.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.