SCAL-335453-POC Flatten app init payload and simplify the spotter init-data builders - #656
Open
shivam-kumar-ts wants to merge 2 commits into
Open
SCAL-335453-POC Flatten app init payload and simplify the spotter init-data builders#656shivam-kumar-ts wants to merge 2 commits into
shivam-kumar-ts wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request flattens the APP_INIT payload structure across various embed components (such as AppEmbed, SpotterEmbed, LiveboardEmbed, and SearchEmbed) by moving properties like spotterSidebarConfig, spotterVizConfig, spotterShareConversationConfig, starterPrompts, and visualOverridesParams out of the nested embedParams object and directly to the top-level data structure. Corresponding utility functions and unit tests have been updated to reflect this change. Feedback is provided regarding several JSDoc comments that use the British spelling 'initialisation' instead of the American English 'initialization', violating the repository style guide.
commit: |
shivam-kumar-ts
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.