fix(igc): invalid condition for igc_power_down_phy_copper()#671
Merged
Koichi98 merged 3 commits intotier4:mainfrom Mar 5, 2026
Merged
fix(igc): invalid condition for igc_power_down_phy_copper()#671Koichi98 merged 3 commits intotier4:mainfrom
igc_power_down_phy_copper()#671Koichi98 merged 3 commits intotier4:mainfrom
Conversation
Signed-off-by: Yuuki Takano <ytakanoster@gmail.com>
Signed-off-by: Yuuki Takano <ytakanoster@gmail.com>
ytakano
changed the title
igc_power_down_phy_copper()
Koichi98
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
igc_power_down_phy_copper()must be called ifIGC_MANC_BLK_PHY_RST_ON_IDEofIGC_MANCis true.Related links
igc_power_down_phy_copper_base(): https://github.com/openbsd/src/blob/b9fa15100f2abf11eab19098a398a4a5c5823ab4/sys/dev/pci/igc_base.c#L108-L109igc_check_reset_block_generic(): https://github.com/openbsd/src/blob/b9fa15100f2abf11eab19098a398a4a5c5823ab4/sys/dev/pci/igc_phy.c#L123-L124How was this PR tested?
Notes for reviewers