machine: use patch.NewHelper instead of client.Update() in takeHardwareOwnership()
#511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ardwareOwnership()` - should reduce contention on the Hardware object - avoids relying on the github.com/tinkerbell/tinkerbell/api version for the Hardware structure too much Signed-off-by: Ricardo Pardini <[email protected]>
Member
Author
|
I've ran with this for a few weeks. No new troubles, and it allows the TB Hardware CRD to change independently of CAPT. |
…entUpdate-in-takeHardwareOwnership
16 tasks
Contributor
Merge Queue Status✅ The pull request has been merged at e54a134 This pull request spent 2 minutes 28 seconds in the queue, including 2 minutes 17 seconds running CI. Required conditions to merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ricardo Pardini [email protected]