-
Notifications
You must be signed in to change notification settings - Fork 221
Improve React, Vuejs and Angular integration pages #3948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: tinymce/8
Are you sure you want to change the base?
Conversation
…om the bundling with webpack guide
modules/ROOT/partials/integrations/angular-load-tinymce-independently.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Millie <[email protected]>
| [source,sh] | ||
| ---- | ||
| ng build | ||
| ng serve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should point out since you combined the cd with the npm install the user is in the wrong directory to run this command...
| + | ||
| [source,sh] | ||
| ---- | ||
| ng serve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same problem as before, the current directory is still the directory above the folder we want to serve...
| [source,sh] | ||
| ---- | ||
| npm install tinymce @tinymce/tinymce-angular | ||
| npm install tinymce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you not in the wrong directory?
tiny-james
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just go and check that you are in the correct directory in the steps please.
Will also resolve: TINY-13508
Site: Staging branch
Updated pages:
Changes:
Pre-checks:
feature/<version>/,hotfix/<version>/,staging/<version>/, orrelease/<version>/.modules/ROOT/nav.adochas been updated(if applicable).Included arelease noteentry for anyNew product features.If this is a minor release, updatedproductminorversioninantora.ymland added new supported versions entry inmodules/ROOT/partials/misc/supported-versions.adoc.Review: