-
Notifications
You must be signed in to change notification settings - Fork 6
Adding RubyLLM Support #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 3 commits
14bb1e6
987d252
6b2bc5f
3e0b4c5
da3f2b4
6509a5d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,6 +30,15 @@ module SpanAttributes | |
|
|
||
| # Deprecated | ||
| TRACELOOP_CORRELATION_ID = "traceloop.correlation.id" | ||
|
|
||
| # Gen AI | ||
| GEN_AI_REQUEST_MODEL = "gen_ai.request.model" | ||
| GEN_AI_RESPONSE_MODEL = "gen_ai.response.model" | ||
| GEN_AI_USAGE_COMPLETION_TOKENS = "gen_ai.usage.completion_tokens" | ||
| GEN_AI_USAGE_PROMPT_TOKENS = "gen_ai.usage.prompt_tokens" | ||
| GEN_AI_COMPLETIONS = "gen_ai.completion" | ||
| GEN_AI_PROMPTS = "gen_ai.prompt" | ||
| GEN_AI_SYSTEM = "gen_ai.system" | ||
|
Comment on lines
34
to
41
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chainVerify Gen AI semantic convention names match OpenTelemetry standards. The Gen AI semantic convention constants should align with the official OpenTelemetry specification. Please verify these attribute names, particularly:
🌐 Web query: 💡 Result: Short answer — OpenTelemetry provides a dedicated set of GenAI (Generative AI) semantic conventions covering four main areas plus provider-specific extensions:
If you want, I can: (a) extract the full list of metric names and their units/attributes, (b) paste the main span attribute tables for quick copy/paste, or (c) point you to the exact spec pages for each signal. Sources: OpenTelemetry GenAI spec pages and repo. [1] [2] [3] [5] [6] References Correct Gen AI semantic convention constant names to match OpenTelemetry specification. The official OpenTelemetry specification uses event names Additionally, the official specification defines token usage as a single metric Update lines 37-40 to use the correct attribute names from the current OpenTelemetry semantic conventions specification. 🤖 Prompt for AI Agents |
||
| end | ||
|
|
||
| module LLMRequestTypeValues | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,16 +6,21 @@ module Traceloop | |
| module SDK | ||
| class Traceloop | ||
| def initialize | ||
| api_key = ENV["TRACELOOP_API_KEY"] | ||
| raise "TRACELOOP_API_KEY environment variable is required" if api_key.nil? || api_key.empty? | ||
|
|
||
| OpenTelemetry::SDK.configure do |c| | ||
| c.add_span_processor( | ||
| OpenTelemetry::SDK::Trace::Export::SimpleSpanProcessor.new( | ||
| OpenTelemetry::SDK::Trace::Export::BatchSpanProcessor.new( | ||
| OpenTelemetry::Exporter::OTLP::Exporter.new( | ||
| endpoint: "#{ENV.fetch("TRACELOOP_BASE_URL", "https://api.traceloop.com")}/v1/traces", | ||
| headers: { "Authorization" => "Bearer #{ENV.fetch("TRACELOOP_API_KEY")}" } | ||
| headers: { | ||
| "Authorization" => "#{ENV.fetch("TRACELOOP_AUTH_SCHEME", "Bearer")} #{ENV.fetch("TRACELOOP_API_KEY")}" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what is that?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. authorization headers may vary in type. i.e. for our dynatrace exporter, they use Api-Token. |
||
| } | ||
| ) | ||
| ) | ||
| ) | ||
| puts "Traceloop exporting traces to #{ENV.fetch("TRACELOOP_BASE", "https://api.traceloop.com")}" | ||
| puts "Traceloop exporting traces to #{ENV.fetch("TRACELOOP_BASE_URL", "https://api.traceloop.com")}" | ||
| end | ||
|
|
||
| @tracer = OpenTelemetry.tracer_provider.tracer("Traceloop") | ||
|
|
@@ -41,25 +46,30 @@ def log_messages(messages) | |
| def log_prompt(system_prompt="", user_prompt) | ||
| unless system_prompt.empty? | ||
| @span.add_attributes({ | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::LLM_PROMPTS}.0.role" => "system", | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::LLM_PROMPTS}.0.content" => system_prompt, | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::LLM_PROMPTS}.1.role" => "user", | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::LLM_PROMPTS}.1.content" => user_prompt | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::GEN_AI_PROMPTS}.0.role" => "system", | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::GEN_AI_PROMPTS}.0.content" => system_prompt, | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::GEN_AI_PROMPTS}.1.role" => "user", | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::GEN_AI_PROMPTS}.1.content" => user_prompt | ||
| }) | ||
| else | ||
| @span.add_attributes({ | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::LLM_PROMPTS}.0.role" => "user", | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::LLM_PROMPTS}.0.content" => user_prompt | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::GEN_AI_PROMPTS}.0.role" => "user", | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::GEN_AI_PROMPTS}.0.content" => user_prompt | ||
| }) | ||
| end | ||
| end | ||
|
|
||
| def log_response(response) | ||
| if response.respond_to?(:body) | ||
| log_bedrock_response(response) | ||
| # Check for RubyLLM::Message objects | ||
| elsif response.is_a?(::RubyLLM::Message) | ||
| log_ruby_llm_message(response) | ||
| elsif response.is_a?(::RubyLLM::Tool::Halt) | ||
| log_ruby_llm_halt(response) | ||
| # This is Gemini specific, see - | ||
| # https://github.com/gbaptista/gemini-ai?tab=readme-ov-file#generate_content | ||
| elsif response.has_key?("candidates") | ||
| elsif response.respond_to?(:has_key?) && response.has_key?("candidates") | ||
| log_gemini_response(response) | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| else | ||
| log_openai_response(response) | ||
|
|
@@ -73,10 +83,29 @@ def log_gemini_response(response) | |
|
|
||
| @span.add_attributes({ | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::LLM_COMPLETIONS}.0.role" => "assistant", | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::LLM_COMPLETIONS}.0.content" => response.dig("candidates", 0, "content", "parts", 0, "text") | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::LLM_COMPLETIONS}.0.content" => response.dig( | ||
| "candidates", 0, "content", "parts", 0, "text") | ||
| }) | ||
| end | ||
|
|
||
| def log_ruby_llm_message(response) | ||
| @span.add_attributes({ | ||
| OpenTelemetry::SemanticConventionsAi::SpanAttributes::GEN_AI_RESPONSE_MODEL => response.model_id, | ||
| OpenTelemetry::SemanticConventionsAi::SpanAttributes::GEN_AI_USAGE_COMPLETION_TOKENS => response.output_tokens || 0, | ||
| OpenTelemetry::SemanticConventionsAi::SpanAttributes::GEN_AI_USAGE_PROMPT_TOKENS => response.input_tokens || 0, | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::GEN_AI_COMPLETIONS}.0.role" => response.role.to_s, | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::GEN_AI_COMPLETIONS}.0.content" => response.content | ||
| }) | ||
| end | ||
|
|
||
| def log_ruby_llm_halt(response) | ||
| @span.add_attributes({ | ||
| OpenTelemetry::SemanticConventionsAi::SpanAttributes::GEN_AI_RESPONSE_MODEL => @model, | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::GEN_AI_COMPLETIONS}.0.role" => "tool", | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::GEN_AI_COMPLETIONS}.0.content" => response.content | ||
| }) | ||
| end | ||
|
|
||
| def log_bedrock_response(response) | ||
| body = JSON.parse(response.body.read()) | ||
|
|
||
|
|
@@ -109,15 +138,20 @@ def log_openai_response(response) | |
| }) | ||
| if response.has_key?("usage") | ||
| @span.add_attributes({ | ||
| OpenTelemetry::SemanticConventionsAi::SpanAttributes::LLM_USAGE_TOTAL_TOKENS => response.dig("usage", "total_tokens"), | ||
| OpenTelemetry::SemanticConventionsAi::SpanAttributes::LLM_USAGE_COMPLETION_TOKENS => response.dig("usage", "completion_tokens"), | ||
| OpenTelemetry::SemanticConventionsAi::SpanAttributes::LLM_USAGE_PROMPT_TOKENS => response.dig("usage", "prompt_tokens"), | ||
| OpenTelemetry::SemanticConventionsAi::SpanAttributes::LLM_USAGE_TOTAL_TOKENS => response.dig("usage", | ||
| "total_tokens"), | ||
| OpenTelemetry::SemanticConventionsAi::SpanAttributes::LLM_USAGE_COMPLETION_TOKENS => response.dig( | ||
| "usage", "completion_tokens"), | ||
| OpenTelemetry::SemanticConventionsAi::SpanAttributes::LLM_USAGE_PROMPT_TOKENS => response.dig("usage", | ||
| "prompt_tokens"), | ||
| }) | ||
| end | ||
| if response.has_key?("choices") | ||
| @span.add_attributes({ | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::LLM_COMPLETIONS}.0.role" => response.dig("choices", 0, "message", "role"), | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::LLM_COMPLETIONS}.0.content" => response.dig("choices", 0, "message", "content") | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::LLM_COMPLETIONS}.0.role" => response.dig( | ||
| "choices", 0, "message", "role"), | ||
| "#{OpenTelemetry::SemanticConventionsAi::SpanAttributes::LLM_COMPLETIONS}.0.content" => response.dig( | ||
| "choices", 0, "message", "content") | ||
| }) | ||
| end | ||
| end | ||
|
|
@@ -126,7 +160,8 @@ def log_openai_response(response) | |
| def llm_call(provider, model) | ||
| @tracer.in_span("#{provider}.chat") do |span| | ||
| span.add_attributes({ | ||
| OpenTelemetry::SemanticConventionsAi::SpanAttributes::LLM_REQUEST_MODEL => model, | ||
| OpenTelemetry::SemanticConventionsAi::SpanAttributes::GEN_AI_REQUEST_MODEL => model, | ||
| OpenTelemetry::SemanticConventionsAi::SpanAttributes::GEN_AI_SYSTEM => provider | ||
| }) | ||
| yield Tracer.new(span, provider, model) | ||
| end | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just replace the existing ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and remove references to llm semantics?