Skip to content

Conversation

@kaoudis
Copy link
Contributor

@kaoudis kaoudis commented Aug 21, 2024

No description provided.

@kaoudis kaoudis requested a review from ESultanik as a code owner August 21, 2024 20:41
@kaoudis kaoudis self-assigned this Aug 22, 2024
Copy link
Collaborator

@hbrodin hbrodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just tiny nit that you might want to address.

README.md Outdated
variables that PolyTracker supports is:

```
```bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I guess this isn't really bash... I'd just leave it without the bash language specifier

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the trunk tool is upset if we leave it unspecified - I was kind of stumped on what to put. Looks like we can select from a few different "shell" choices; I think I'll try shell-script since that's sort of closer heh.

@kaoudis kaoudis merged commit 5542da1 into master Nov 27, 2024
6 checks passed
@kaoudis kaoudis deleted the kaoudis/readme-update branch November 27, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants