-
Notifications
You must be signed in to change notification settings - Fork 20
Standardize signature parity testing, add Docker for testing #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 9 9
Lines 302 302
Branches 39 39
=======================================
Hits 299 299
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Not sure what is idiomatic here. Should we remove this from the gem completely (but then you can't use it to fully test itself anymore?) |

The Node SDK now has cli support for signing payloads, we can use it to compare our own signatures instead of handrolled Node.js code in this repo:
As an aside, I added Docker so it's easier to test this SDK on machines that do not have the Ruby environment set up.