Skip to content

Conversation

@matt-aitken
Copy link
Member

@matt-aitken matt-aitken commented Jan 16, 2026

Fix schedule counting

  • Inactive TaskSchedule not counted
  • Inactive environments (archived preview branches) not counted

Clarified per-project limits descriptions.

The TaskSchedule is inactive but instance is still active. I’ve
verified the query performance on prod.
@changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2026

⚠️ No Changeset found

Latest commit: aea5347

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026

Walkthrough

This PR updates two files: one adjusts presentation text in LimitsPresenter to change three quota descriptions from “across all projects” to “per project” and renames “Staging environment” to “Staging/Preview environments”; the other tightens the schedule count query in checkSchedule.server.ts by adding top-level active: true, environment.archivedAt: null, and nested taskSchedule.active: true constraints so only active, non-archived schedule instances (with active task schedules) are counted.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is minimal and lacks required template sections. It does not follow the repository's standard PR template with checklist, testing details, or changelog sections. Complete the PR description using the required template: add a checklist for contributing guide and testing, describe testing steps, provide a detailed changelog, and include any relevant screenshots.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: fixing schedule limit counting logic.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vibe-kanban-cloud
Copy link

Review Complete

Your review story is ready!

View Story

Comment !reviewfast on this PR to re-generate the story.

@matt-aitken matt-aitken marked this pull request as ready for review January 16, 2026 12:59
@matt-aitken matt-aitken merged commit 5504e7f into main Jan 16, 2026
32 checks passed
@matt-aitken matt-aitken deleted the fix-schedule-counting branch January 16, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants