fix(webapp): use native controls for inline actions - #4698
Conversation
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
b5b6fc4 to
4e4e4ba
Compare
c1a7435 to
d6f6545
Compare
Only mount the tooltip subtree for a copyable cell while it is hovered; the plain button (with its aria-label) stays mounted at all times so keyboard users can always reach it. Also give the icon-only CopyButton an accessible name when it renders without children.
The copy-cell tooltip was wired to a controlled `open` state that followed the whole cell's hover, so it popped open over neighbouring content whenever the pointer crossed any part of the cell instead of just the copy button. Leave the tooltip uncontrolled so Radix opens it only when the pointer or keyboard focus lands on the button itself; the button still stays permanently mounted so it keeps its place in the tab order.
7ccd921 to
b043570
Compare
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
Summary
Replace mouse-only dashboard actions with native buttons.
Copy, remove, and stop-generation controls now expose keyboard focus and accessible names. Hover-revealed actions remain mounted so keyboard users can discover them, and a decorative clipboard icon no longer captures clicks.
Base: #4697