Skip to content

fix(webapp): use native controls for inline actions - #4698

Merged
carderne merged 7 commits into
fix/webapp-checkbox-semantics-tri-13381from
fix/webapp-native-action-controls-tri-13381
Aug 19, 2026
Merged

fix(webapp): use native controls for inline actions#4698
carderne merged 7 commits into
fix/webapp-checkbox-semantics-tri-13381from
fix/webapp-native-action-controls-tri-13381

Conversation

@carderne

@carderne carderne commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Replace mouse-only dashboard actions with native buttons.

Copy, remove, and stop-generation controls now expose keyboard focus and accessible names. Hover-revealed actions remain mounted so keyboard users can discover them, and a decorative clipboard icon no longer captures clicks.

Base: #4697

@changeset-bot

changeset-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b043570

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4c5d54e3-b882-47c0-8eb9-3a34e0280683

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@carderne
carderne marked this pull request as ready for review August 19, 2026 11:23
devin-ai-integration[bot]

This comment was marked as resolved.

@carderne
carderne force-pushed the fix/webapp-native-action-controls-tri-13381 branch from b5b6fc4 to 4e4e4ba Compare August 19, 2026 11:48
@carderne
carderne force-pushed the fix/webapp-native-action-controls-tri-13381 branch 2 times, most recently from c1a7435 to d6f6545 Compare August 19, 2026 11:50
devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

Only mount the tooltip subtree for a copyable cell while it is
hovered; the plain button (with its aria-label) stays mounted at all
times so keyboard users can always reach it. Also give the icon-only
CopyButton an accessible name when it renders without children.
The copy-cell tooltip was wired to a controlled `open` state that
followed the whole cell's hover, so it popped open over neighbouring
content whenever the pointer crossed any part of the cell instead of
just the copy button. Leave the tooltip uncontrolled so Radix opens
it only when the pointer or keyboard focus lands on the button
itself; the button still stays permanently mounted so it keeps its
place in the tab order.
@carderne
carderne force-pushed the fix/webapp-native-action-controls-tri-13381 branch from 7ccd921 to b043570 Compare August 19, 2026 14:54
@pkg-pr-new

pkg-pr-new Bot commented Aug 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@b043570

trigger.dev

npm i https://pkg.pr.new/trigger.dev@b043570

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@b043570

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@b043570

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@b043570

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@b043570

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@b043570

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@b043570

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@b043570

commit: b043570

@carderne
carderne merged commit 73c8a4d into main Aug 19, 2026
39 checks passed
@carderne
carderne deleted the fix/webapp-native-action-controls-tri-13381 branch August 19, 2026 15:36
carderne added a commit that referenced this pull request Aug 19, 2026
## Summary

Make time-filter mode selection keyboard accessible.

Duration and exact-range modes now use native pressed buttons. Nested
date, duration, and quick-select controls no longer depend on click
propagation blockers.

Base: [#4698](#4698)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants