Improve documentation #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koszti
reviewed
Dec 8, 2025
| 1. First you build the TypeScript into Javascript and CSS | ||
| 2. Then copy the distributable path into Trino. | ||
| 3. Then modify Trino to respond to the query ui path. | ||
|
|
Member
There was a problem hiding this comment.
Do we still need this section? It applies only to the old UI and now that the query UI has moved to MUI and a standalone react component I doubt this is something we want to support for the current trino UI.
Member
Author
There was a problem hiding this comment.
I think we should leave it in place until its available as a feature that can be toggled in the preview UI at least. Afterwards we can probably remove it
koszti
reviewed
Dec 8, 2025
| npm run build | ||
| ``` | ||
|
|
||
| ### Copying into Trino |
Member
There was a problem hiding this comment.
same as above. It applies only to the old/current UI. do we still want to support it? it's bit of a manual magic.
koszti
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a shorter readme for npmjs.org and cleaning the main readme a bit.
Additional context and related issues