Skip to content

Conversation

@mosabua
Copy link
Member

@mosabua mosabua commented Dec 7, 2025

Will update docs after the docs improvement PR is merged.

@cla-bot cla-bot bot added the cla-signed label Dec 7, 2025
Copy link
Member

@koszti koszti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add it two more places:

  1. in README.md at

    * Uses Node.js v20+

  2. and a new engines entry in the package.json at

This will make sure to fail things as early as possible whenever and elder node is being used:

...
  "engines": {
    "node": ">=24"
  },
  "type": "module",
...

@mosabua
Copy link
Member Author

mosabua commented Dec 9, 2025

Yes .. let me do that before we merge this and after I rebased to the other changes.

@mosabua mosabua changed the title Use Node.js 24 (WIP) Use Node.js 24 Dec 9, 2025
@mosabua mosabua force-pushed the upmore branch 2 times, most recently from bf741b4 to e165f48 Compare December 15, 2025 04:14
@mosabua mosabua changed the title (WIP) Use Node.js 24 Use and enforce Node.js 24 Dec 15, 2025
@mosabua
Copy link
Member Author

mosabua commented Dec 15, 2025

Done .. should be good to go now @koszti

Ran all builds and tested example app locally.

@mosabua
Copy link
Member Author

mosabua commented Dec 15, 2025

I am merging this PR since it all works and I need a consistent base for the real work that happens in #26 so we can drive to a new release either before or after those updates.

@mosabua mosabua merged commit 999c118 into trinodb:main Dec 15, 2025
2 checks passed
@mosabua mosabua deleted the upmore branch December 15, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants