Simplify JiraInstallationType Enum Naming (Optional Enhancement)#4573
Closed
shahzadhaider1 wants to merge 2 commits intotrufflesecurity:mainfrom
Closed
Simplify JiraInstallationType Enum Naming (Optional Enhancement)#4573shahzadhaider1 wants to merge 2 commits intotrufflesecurity:mainfrom
shahzadhaider1 wants to merge 2 commits intotrufflesecurity:mainfrom
Conversation
… prefix instead of JIRA_INSTALLATION_TYPE_ to improve readability while maintaining collision avoidance.
mustansir14
approved these changes
Dec 8, 2025
martinlocklear
approved these changes
Dec 10, 2025
Contributor
martinlocklear
left a comment
There was a problem hiding this comment.
Nice! I honestly think we could go even further here, and just have something like this:
enum JiraInstallationType {
AUTODETECT = 0;
CLOUD = 1;
DATA_CENTER = 2;
}
Your call of course.
Please confirm that this isn't a breaking change anywhere downstream before merging in (I did a quick look and I think it will be fine.)
Contributor
Author
|
kashifkhan0771
approved these changes
Dec 11, 2025
Contributor
Author
|
Closing as it looks like an extra effort. Will re-open if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary (Optional Enhancement)
Simplify JiraInstallationType enum value names to improve readability.
Changes
Before:
After:
Rationale
The initial naming used
JIRA_INSTALLATION_TYPE_prefix to avoid collisions with Bitbucket's enum values in the same proto package. However, this was unnecessarily verbose compared to Bitbucket's cleaner naming pattern.The shorter
JIRA_prefix:Generated Code Impact
Breaking Changes
None
Checklist:
make test-community)?make lintthis requires golangci-lint)?