Update deprecated tldextract property #176
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_under_public_suffix
bmos
force-pushed
the
tldextract_deprecation
branch
from
e27ceee to
58cefbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tldextract has deprecated the registered_domain property in favor of the more clearly named top_domain_under_public_suffix.
While this isn't broken yet, it will be broken at some point in the future and, as requestium doesn't support tldextract versions below the one with the deprecation, it makes sense to update it.
Test failures are not due to this PR, they're issues with the tests themselves when used in Github Actions. The tests pass locally. If you merge #175, this PR should pass all checks once updated.