Skip to content

Automatically output per-issue SVGs for schematic placement checks - #4641

Open
seveibar wants to merge 3 commits into
mainfrom
feat/schematic-placement-svg-artifacts
Open

Automatically output per-issue SVGs for schematic placement checks#4641
seveibar wants to merge 3 commits into
mainfrom
feat/schematic-placement-svg-artifacts

Conversation

@seveibar

@seveibar seveibar commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

tsci check schematic-placement [file] now automatically writes one SVG per reported issue to dist/schematic-placement/ and prints each output path alongside the existing analysis text. Each SVG contains the cropped schematic, one issue overlay, and only that issue's XML description underneath.

Uses the newly merged createSchematicPlacementIssueArtifacts() API and reuses the analysis instead of running the solvers twice. Updates the pinned schematic-placement dependency and lockfile. Reruns remove only previously generated issue SVGs so resolved issues do not leave stale reports; other files are preserved, and a clean first run creates no output directory.

Validation:

  • All 3 schematic-placement CLI integration tests pass, covering TSX and prebuilt Circuit JSON, emitted artifact contents/paths, clean results, stale-report cleanup, and preservation of unrelated files.
  • Typecheck, repository format check, frozen-lockfile install, and CLI build pass.
  • Built CLI smoke test against the real wireless-mouse sensor export writes all 5 issue SVGs (3 trace simplification reports and 2 orientation reports).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant