Automatically output per-issue SVGs for schematic placement checks - #4641
Open
seveibar wants to merge 3 commits into
Open
Automatically output per-issue SVGs for schematic placement checks#4641seveibar wants to merge 3 commits into
seveibar wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tsci check schematic-placement [file]now automatically writes one SVG per reported issue todist/schematic-placement/and prints each output path alongside the existing analysis text. Each SVG contains the cropped schematic, one issue overlay, and only that issue's XML description underneath.Uses the newly merged
createSchematicPlacementIssueArtifacts()API and reuses the analysis instead of running the solvers twice. Updates the pinned schematic-placement dependency and lockfile. Reruns remove only previously generated issue SVGs so resolved issues do not leave stale reports; other files are preserved, and a clean first run creates no output directory.Validation: