Skip to content

Stop retrying exhausted empty single-route searches #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShiboSoftwareDev wants to merge 2 commits into
base: repro/h3-empty-solo-rerips
Choose a base branch
from
Open

Stop retrying exhausted empty single-route searches #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e46c91a
fix: stop unchanged empty single-route retries
Nov 10, 2026
d1eb2ba
Merge branch 'repro/h3-empty-solo-rerips' into fix/stop-empty-single-…
Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion lib/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1919,11 +1919,24 @@ export class TinyHyperGraphSolver extends BaseSolver {
})
}

onOutOfCandidates() {
onOutOfCandidates(): void {
const { topology, state } = this
const currentRouteId = state.currentRouteId
const maxRegionCostBeforeRip = this.getMaxRegionCost()

// An empty single-route search has nothing to move out of its way.
if (
this.problem.routeCount === 1 &&
!this.problem.initialAssignments?.length &&
maxRegionCostBeforeRip === 0 &&
state.portAssignment.every((netId) => netId === -1) &&
state.regionSegments.every((segments) => segments.length === 0)
) {
this.failed = true
this.error = `No path for ${this.getRouteConnectionId(0)}`
return
}

for (let regionId = 0; regionId < topology.regionCount; regionId++) {
const regionCost =
state.regionIntersectionCaches[regionId]?.existingRegionCost ?? 0
Expand Down
Loading
Loading