Skip to content

Fix #266 : nob__walk_dir_opt_impl() trying to close zeroed handle for non directory entries #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whophi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #266 : nob__walk_dir_opt_impl() trying to close zeroed handle for non directory entries #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nob.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2100,7 +2100,7 @@ NOBDEF bool nob_dir_entry_next(Nob_Dir_Entry *dir)
NOBDEF void nob_dir_entry_close(Nob_Dir_Entry dir)
{
#ifdef _WIN32
FindClose(dir.nob__private.win32_hFind);
if (dir->nob__private.win32_hFind != INVALID_HANDLE_VALUE) FindClose(dir.nob__private.win32_hFind);
#else
if (dir.nob__private.posix_dir) closedir(dir.nob__private.posix_dir);
#endif
Expand Down Expand Up @@ -2190,7 +2190,7 @@ bool nob__walk_dir_opt_impl(Nob_String_Builder *file_path, Nob_Walk_Func func, s
file_path->count = saved_file_path_count;
nob_da_last(file_path) = '\0';

nob_dir_entry_close(dir);
if (file_type == NOB_FILE_DIRECTORY) nob_dir_entry_close(dir);
return result;
}

Expand Down