🧹 Modernize logging formatting and fix incorrect placeholder#8
🧹 Modernize logging formatting and fix incorrect placeholder#8
Conversation
Fixed an issue in `cfgcaddy/utils.py` where a logging call was using
`{}` as a placeholder instead of the standard `%s` when passing
arguments separately to the logger. This would cause a `TypeError`.
Additionally, modernized all other logging calls in the codebase to
use `%s` placeholders and lazy interpolation instead of `.format()`,
improving overall code health and maintainability.
Co-authored-by: tstapler <3860386+tstapler@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: Fixed an incorrect logging formatting placeholder in
cfgcaddy/utils.pyand modernized all other logging calls in the codebase.💡 Why: The incorrect placeholder caused a
TypeError. Modernizing all calls to use%swith lazy interpolation is a code health best practice for standard Python logging.✅ Verification: Verified with a reproduction script that demonstrated the fix for the
TypeError. Manually inspected all other changes.✨ Result: Improved robustness and maintainability of the logging throughout the codebase.
PR created automatically by Jules for task 686423967702998236 started by @tstapler