[pull] master from php:master - #1268
Merged
Merged
Conversation
The conversion of the data parameter to Z_PARAM_PATH_STR() made pg_lo_write() reject any data containing a null byte, breaking writes of arbitrary binary payloads which were accepted before. Accept embedded null bytes again by parsing the data as a length-aware string. Sibling audit: the other Z_PARAM_PATH* conversions from the same change (pg_connect(), pg_lo_import(), table/statement identifiers) operate on paths or SQL text where null-byte rejection is intentional. Closes GH-23649
* PHP-8.5: ext/pgsql: Restore binary-safe pg_lo_write()
__construct filled to_cache/from_cache via php_converter_resolve_callback, so a clone, which never runs the constructor, kept both FCCs zeroed and the first callback-worthy convert called zend_call_known_fcc on a NULL handler. Resolve both caches in php_converter_object_ctor so every allocation path gets them. Closes GH-23324
* PHP-8.5: ext/intl: Resolve UConverter callbacks when the object is allocated
This hack is slightly faster than the original one. My local benchmarks show approximately 39% lower runtime for a single NUL byte.
* PHP-8.4: Avoid closing libxml output encoder twice (#23678)
* PHP-8.5: Avoid closing libxml output encoder twice (#23678)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )