Fix the default filter fallback reusing a null-safe temporary variable - #4915
Merged
Conversation
lazerg
force-pushed
the
fix/issue-4914-default-null-safe
branch
from
September 1, 2026 11:06
2616498 to
86c830e
Compare
fabpot
approved these changes
Sep 3, 2026
Contributor
|
Thank you @lazerg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
defaultfilter reuses the fallback argument node in both branches of the conditional it compiles to. BecauseGetAttrExpressionrecords the temporary variable it allocated for a null-safe chain on the node itself, the second compilation skipped the assignment and emitted a bare$_vNreference, so{{ item?.label|default(item?.name) }}warned about an undefined variable wheneveritemwas null.The fallback node is now cloned, like the node used for the defined test already is, so each branch compiles its own temporary.
Fixes #4914