Fix WorkScheduler.schedule() to actually schedule work#168
Open
prjanitor wants to merge 1 commit intotylerbwong:masterfrom
Open
Fix WorkScheduler.schedule() to actually schedule work#168prjanitor wants to merge 1 commit intotylerbwong:masterfrom
prjanitor wants to merge 1 commit intotylerbwong:masterfrom
Conversation
The schedule() method was only canceling all work but never calling scheduleNewWork() to schedule the configured work requests. This means no background work would ever be scheduled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
The
schedule()method inWorkSchedulerwas only callingworkManager.cancelAllWork()but never actually scheduling any work. ThescheduleNewWork()method existed with the correct logic but was never invoked.Fix
Added a call to
scheduleNewWork()aftercancelAllWork()in theschedule()method. This ensures that:Files Changed
app/src/main/kotlin/me/tylerbwong/stack/data/work/WorkScheduler.ktTesting
This fix ensures that background work (bookmarks sync, sites sync) will actually be scheduled when
schedule()is called.This PR was generated by PRJanitor — an automated tool that finds and fixes small bugs in open-source projects.
We respect your contribution guidelines — if your project doesn't accept bot PRs, we won't send more. You can also add a
.github/prjanitor.ymlfile withenabled: falseto opt out explicitly.