Skip to content

Update sbt-header to 5.11.0#835

Open
mzuehlke wants to merge 4 commits intotypelevel:mainfrom
mzuehlke:update-sbt-header
Open

Update sbt-header to 5.11.0#835
mzuehlke wants to merge 4 commits intotypelevel:mainfrom
mzuehlke:update-sbt-header

Conversation

@mzuehlke
Copy link
Collaborator

@mzuehlke mzuehlke commented Sep 12, 2025

closes: #833

@mergify mergify bot added the core label Sep 12, 2025
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to need to be a major version bump of this plugin, I think.

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Should bump the base version appropriately in this PR. Any compelling reasons to make this update?

@mzuehlke
Copy link
Collaborator Author

Correct
I will update the PR to update the base version

@rossabaker
Copy link
Member

This update will be necessary for eventual SBT 2 support, I think? I don't think it's urgent in the short term, but needed in the long term.

I'm also contemplating an improvement to sbt-header's SPDX handling. That would be a subsequent release.

@mzuehlke
Copy link
Collaborator Author

As @rossabaker sad, we will need a newer version latest when we want to support sbt 2.
In the meantime it depends if we want to always include updates to all used sbt plugins.
Which would lead to more often base version bumps. Or do this very selectively.

@satorg satorg requested a review from armanbilge February 15, 2026 19:43
@satorg
Copy link
Contributor

satorg commented Feb 15, 2026

Just checknig – is there anything missing in the pull request that is blocking it from getting merged?

@satorg
Copy link
Contributor

satorg commented Feb 24, 2026

@mzuehlke , could you update your branch and resolve conflicts please?
It looks like your PR is otherwise pretty much ready to go to main.
Thank you!

# Conflicts:
#	build.sbt
#	core/build.sbt
@mzuehlke
Copy link
Collaborator Author

@satorg I updated the PR

@satorg
Copy link
Contributor

satorg commented Feb 27, 2026

@armanbilge , the PR shows it can’t be merged because your review still requests changes. As far as I can tell, the requested changes have been addressed. Could you take another look and clear it when you have a moment?

@armanbilge
Copy link
Member

@satorg thanks. Just to clarify, is there a compelling reason to do a new major version of sbt-tl soon? I know we have a bunch of accumulated update PRs that require breaking bumps, but besides that?

@satorg
Copy link
Contributor

satorg commented Feb 27, 2026

@armanbilge , my honest answer is no: I don't have a compelling reason besides keeping the dependencies up-to-date.

We could fork series/0.9 branch out of main, if bumping the latter up is a concern 🤔

@armanbilge
Copy link
Member

Sure, we could make a series/0.9 branch (do you have sufficient perms on this repo to do that?). Or, just keep these PRs on ice for now 😅

@satorg
Copy link
Contributor

satorg commented Feb 27, 2026

do you have sufficient perms on this repo to do that?

I guess, I could create the branch... But someone else's help is needed to configure it and setup CI/CD.

Or, just keep these PRs on ice for now 😅

That's certainly an option. I'm just not sure what the signal whould be for us to un-ice those PRs.
On the other hand, if we could release, say, v0.9.0-M1 and let everyone test it out, then it would defenitely help expedite the migration.

@armanbilge
Copy link
Member

I'm just not sure what the signal whould be for us to un-ice those PRs.

We will eventually have to bump to 0.9 for some reason. You can check previous releases for examples of why we decided to bump. That would be the signal :)

then it would defenitely help expedite the migration.

Somewhat. A breaking bump in sbt-tl forces a breaking bump of other plugins in its ecosystem, which is why we try to avoid it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants