Conversation
rossabaker
left a comment
There was a problem hiding this comment.
This is going to need to be a major version bump of this plugin, I think.
armanbilge
left a comment
There was a problem hiding this comment.
Indeed. Should bump the base version appropriately in this PR. Any compelling reasons to make this update?
|
Correct |
|
This update will be necessary for eventual SBT 2 support, I think? I don't think it's urgent in the short term, but needed in the long term. I'm also contemplating an improvement to sbt-header's SPDX handling. That would be a subsequent release. |
|
As @rossabaker sad, we will need a newer version latest when we want to support sbt 2. |
|
Just checknig – is there anything missing in the pull request that is blocking it from getting merged? |
|
@mzuehlke , could you update your branch and resolve conflicts please? |
# Conflicts: # build.sbt # core/build.sbt
|
@satorg I updated the PR |
|
@armanbilge , the PR shows it can’t be merged because your review still requests changes. As far as I can tell, the requested changes have been addressed. Could you take another look and clear it when you have a moment? |
|
@satorg thanks. Just to clarify, is there a compelling reason to do a new major version of sbt-tl soon? I know we have a bunch of accumulated update PRs that require breaking bumps, but besides that? |
|
@armanbilge , my honest answer is no: I don't have a compelling reason besides keeping the dependencies up-to-date. We could fork |
|
Sure, we could make a |
I guess, I could create the branch... But someone else's help is needed to configure it and setup CI/CD.
That's certainly an option. I'm just not sure what the signal whould be for us to un-ice those PRs. |
We will eventually have to bump to 0.9 for some reason. You can check previous releases for examples of why we decided to bump. That would be the signal :)
Somewhat. A breaking bump in sbt-tl forces a breaking bump of other plugins in its ecosystem, which is why we try to avoid it. |
closes: #833