-
-
Notifications
You must be signed in to change notification settings - Fork 16
Add keyboard labels symbols #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
203be55
cbd98e8
1dafd7b
57758e8
f28fa3a
e329d2c
c77bb2b
0346b5e
87d75a9
013383b
4c50d3d
51205ed
660f3bb
07f273f
3510eba
f8df219
c75eab0
050cb9e
9968a54
0777363
646da5e
80b1cb1
c4031b1
a9a97af
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1266,9 +1266,6 @@ errorbar | |
| .circle.stroked ⧲ | ||
| .circle.filled ⧳ | ||
|
|
||
| // Keyboard labels. | ||
| spacebar ␣ | ||
|
|
||
| gender { | ||
| female ♀\vs{text} | ||
| .double ⚢ | ||
|
|
@@ -1323,3 +1320,112 @@ control { | |
| del ␡ // DELete | ||
| nl  // New Line | ||
| } | ||
|
|
||
| // Characters commonly used as keyboards labels | ||
| keyboard { | ||
| linefeed ↴ | ||
| home ↸ | ||
| .alt ⭶ | ||
|
Comment on lines
+1327
to
+1328
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't like that we have two subtly different symbols for the same thing. How did you choose which one to be the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As explained in the linked document, the default one is in a group called "Keyboard symbols and circle arrows" while the other is in a random group (here, "triangle-headed arrows"), but both mention the "home key" and are cross-referenced. So they clearly meant to describe the same key, but the first one is primarily meant to be a key label.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Then I think let's only keep U+21B8 and remove the |
||
| .corner ⇱ | ||
| .phone ⌂ | ||
|
Comment on lines
+1329
to
+1330
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There could be many more variations (like ↖ which I noted previously). In general, I feel like if a semantic name doesn't fit a single symbol (with perhaps a few variants, like
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The difference is that ↖ is not described as "home" in the unicode chart. But if you want we can remove home altogether.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that would be better indeed. If the need for a
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one specifically is not used as a common keyboard key symbol so I don't think it belongs here. |
||
| end ⇲ | ||
| .alt ⭸ | ||
|
Comment on lines
+1331
to
+1332
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is the default for this one not the same as for |
||
| tab ↹ | ||
| .alt ⭾ | ||
| .alt.v ⭿ | ||
| .l ⇤ | ||
| .l.alt ⭰ | ||
| .r ⇥ | ||
| .r.alt ⭲ | ||
| .t ⤒ | ||
| .t.alt ⭱ | ||
| .b ⤓ | ||
| .b.alt ⭳ | ||
|
Comment on lines
+1333
to
+1343
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you have evidence for any variant other than
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My Apple keyboard has U+21E5 on it. |
||
| pageup ⇞ | ||
| pagedown ⇟ | ||
| shift ⇧ | ||
| capslock ⇪ | ||
| .pedestal ⇫ | ||
| .pedestal.struck ⇬ | ||
| .struck ⮸ | ||
|
Comment on lines
+1347
to
+1350
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as https://github.com/typst/codex/pull/164/changes#r3215401498. |
||
| numlock ⇭ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you have evidence of this symbol being used on actual contemporary keyboards? I personally don't associate any symbol with the Num Lock key. |
||
| scroll ⇳ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this a real keyboard key? |
||
| space ␣ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this even present on actual keyboards? I feel like most keyboards simply do not have any symbol on the space bar. |
||
| del ␥ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you have evidence of contemporary real world keyboards that use this symbols? |
||
| erase | ||
| .r ⌦ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this present on any real world keyboard?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Mine uses a filled version of U+2326 with a white cross for delete, next to "delete" written out on the key. |
||
| .l ⌫ | ||
| cmd ⌘ | ||
| enter ⌤ | ||
| .alt ⎆ | ||
|
Comment on lines
+1359
to
+1360
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think most people associate the Enter key with any of those symbols. |
||
| option ⌥ | ||
| clear ⌧ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this a real key on contemporary keyboards?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My Apple keyboard has it (U+2327, tho the X slightly pokes out). But I have no clue what it was meant to represent, since I'm using this keyboard on Linux, where it maps to num lock. |
||
| keyboard ⌨\vs{text} | ||
| .mouse 🖦 | ||
| .wired 🖮 | ||
|
Comment on lines
+1363
to
+1365
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this fits in a submodule dedicated to keyboard key symbols. |
||
| insert ⎀ | ||
| underline | ||
| .continuous ⎁ | ||
| .discontinuous ⎂ | ||
| emph ⎃ | ||
| center ⎅ | ||
|
Comment on lines
+1366
to
+1371
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you have evidence of contemporary keyboards that have dedicated keys for those functions? |
||
| alt ⎇ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you have evidence of contemporary keyboards that use this symbol? |
||
| control ⎈ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you have evidence of contemporary keyboards that use this symbol? |
||
| break ⎊ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What key is that? |
||
| esc ⎋ | ||
| .alt ⮹ | ||
| undo ⎌ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| decimalsep ⎖ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What key is that? |
||
| prevpage ⎗ | ||
| nextpage ⎘ | ||
|
Comment on lines
+1379
to
+1380
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This feels redundant with |
||
| printscreen ⎙ | ||
| clearscreen ⎚ | ||
|
Comment on lines
+1381
to
+1382
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are those symbols used on any real world contemporary keyboard? |
||
| return ⏎ | ||
| .alt ↵ | ||
| .l ⮐ | ||
| .r ⮑ | ||
|
Comment on lines
+1385
to
+1386
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think those can be excluded for now. |
||
| newline | ||
| .alt ↵ | ||
| .l ⮒ | ||
| .r ⮓ | ||
|
Comment on lines
+1387
to
+1390
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there any contemporary keyboard that has a separate key for newline that is not just the Enter key? |
||
| eject ⏏\vs{text} | ||
| // Music/Video player buttons | ||
| forward ⏵ | ||
| .fast ⏩\vs{text} | ||
| backwards ⏴ | ||
| .fast ⏪\vs{text} | ||
| nexttrack ⏭\vs{text} | ||
| prevtrack ⏮\vs{text} | ||
| playpausetoggle ⏯\vs{text} | ||
| alarm ⏰\vs{text} | ||
| stopwatch ⏱\vs{text} | ||
| timer ⏲\vs{text} | ||
| hourglass ⏳\vs{text} | ||
| increase ⏶ | ||
| decrease ⏷ | ||
| pause ⏸\vs{text} | ||
| .alt ⎉ | ||
| stop ⏹\vs{text} | ||
| record ⏺\vs{text} | ||
| shuffle 🔀 | ||
| repeat 🔁 | ||
| .once 🔂 | ||
| reload 🔃 | ||
| .alt 🔄 | ||
|
Comment on lines
+1391
to
+1414
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think let's exclude those from this PR. they can be added in a separate PR so that this one can focus on actual keyboard symbols. |
||
| // Adjust sound and brightness | ||
| brightness | ||
| .decrease 🔅 | ||
| .increase 🔆 | ||
| speaker 🔈\vs{text} | ||
| .mute 🔇 | ||
| .lower 🔉 | ||
| .higher 🔊 | ||
|
Comment on lines
+1415
to
+1422
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I feel like those symbols can be interpreted in a more general way than just keyboard symbols. Let's add them in a separate PR. |
||
| // Power symbols | ||
| power ⏻ | ||
| .on ⏽ | ||
| .off ⭘ | ||
| .on.off ⏼ | ||
| .sleep ⏾ | ||
|
Comment on lines
+1423
to
+1428
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Those are redundant with |
||
| pageup ⭻ | ||
| pagedown ⭽ | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this symbol present on actual keyboards?