-
Notifications
You must be signed in to change notification settings - Fork 824
touying-uge:0.1.0 #3582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
touying-uge:0.1.0 #3582
Conversation
|
Hey, there are some errors in your package that were reported by our CI system. Can you please fix them? Once that's done I'll proceed to a manual review. Let me know if you have questions or need help to fix these issues. |
|
Thank you! It seems that now the issue is due to a |
elegaanz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some small remarks, after that it should be ready to merge.
Regarding the large SVG file, it's fine, the warning is here to bring it to attention in case something is wrong, but if it can't be compressed any further the current size is acceptable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As explained in our docs the thumbnail should be a single page, even if I appreciate the effort of showcasing various slides here. At a lower resolution it wouldn't look too good I think. You can keep this image and re-use it to illustrate your README if you want (or use the individual pages without merging them).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this file is not necessary for users of your package, can you delete it, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check that you are allowed to distribute these logos please? And can you specify in your README under which license/terms they are made available, unless they are under the GPL too?
I am submitting
Description: This project holds a touying template to write presentations for the French Université Gustave Eiffel, according to the graphic charter.
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE