build(go): upgrade toolchain to Go 1.25.0 - #578
Merged
Merged
Conversation
## Summary ### Why? The toolchain was pinned at Go 1.25.0's predecessor, 1.24.5. Nothing in the tree required the bump — this is routine currency, done as its own change so that a later functional PR is not the one that first exercises a new compiler. The pin is duplicated, and the copies are load-bearing in different places. `go.mod` feeds `go_sdk.from_file`, which resolves the hermetic SDK used for host builds and tests. `GO_VERSION` in `MODULE.bazel` is separate and drives the extra linux/amd64 SDK that the `build-*-linux` targets cross-compile the Docker images with. Bumping one and not the other is silent: the host suite stays green while the containers ship a binary built by a different compiler. They move together here. ### What? Four pins, all mechanical: - `go.mod` — the module's Go directive, and by extension the host SDK. - `MODULE.bazel` — `GO_VERSION`, the linux/amd64 cross-compile SDK. - `service/stovepipe/server/Dockerfile.debug` — the `golang:1.24-bookworm` builder stage that supplies delve becomes `golang:1.25-bookworm`, so the debug image's dlv is built by the same major version as the binary it wraps. - `doc/howto/DEVELOPMENT.md` — the stated prerequisite and the troubleshooting note that tells you to match your local Go to `go.mod`. Two things deliberately left alone. The `dlv@v1.24.2` on the line below the Dockerfile bump is a delve release that happens to share the number — unrelated to the Go version. And CI carries no Go pin of its own: the workflows build through Bazel and pick the toolchain up from the two pins above, so there is nothing to change under `.github/`. No source changes. `make tidy`, `make gazelle`, and `make fmt` all produce zero drift on top of these four edits — no `go.sum`, lockfile, or `BUILD.bazel` churn. ## Test Plan ✅ `bazel run @rules_go//go -- version` — reports `go1.25.0 darwin/arm64`, confirming the hermetic SDK actually moved rather than the pin merely being edited. ✅ `make build` — 309 targets. ✅ `make test` — 98/98 pass. ✅ `make tidy` / `make gazelle` / `make fmt` — clean, no generated-file drift. Not run locally: the Docker-based integration and e2e suites, which is where the cross-compiled linux SDK and the rebuilt debug image are first exercised end to end. Those run in CI — worth watching them here specifically rather than treating this as a no-op diff.
behinddwalls
marked this pull request as ready for review
August 12, 2026 03:47
mnoah1
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
The toolchain was pinned at Go 1.25.0's predecessor, 1.24.5. Nothing in the tree required the bump — this is routine currency, done as its own change so that a later functional PR is not the one that first exercises a new compiler.
The pin is duplicated, and the copies are load-bearing in different places.
go.modfeedsgo_sdk.from_file, which resolves the hermetic SDK used for host builds and tests.GO_VERSIONinMODULE.bazelis separate and drives the extra linux/amd64 SDK that thebuild-*-linuxtargets cross-compile the Docker images with. Bumping one and not the other is silent: the host suite stays green while the containers ship a binary built by a different compiler. They move together here.What?
Four pins, all mechanical:
go.mod— the module's Go directive, and by extension the host SDK.MODULE.bazel—GO_VERSION, the linux/amd64 cross-compile SDK.service/stovepipe/server/Dockerfile.debug— thegolang:1.24-bookwormbuilder stage that supplies delve becomesgolang:1.25-bookworm, so the debug image's dlv is built by the same major version as the binary it wraps.doc/howto/DEVELOPMENT.md— the stated prerequisite and the troubleshooting note that tells you to match your local Go togo.mod.Two things deliberately left alone. The
dlv@v1.24.2on the line below the Dockerfile bump is a delve release that happens to share the number — unrelated to the Go version. And CI carries no Go pin of its own: the workflows build through Bazel and pick the toolchain up from the two pins above, so there is nothing to change under.github/.No source changes.
make tidy,make gazelle, andmake fmtall produce zero drift on top of these four edits — nogo.sum, lockfile, orBUILD.bazelchurn.Test Plan
✅
bazel run @rules_go//go -- version— reportsgo1.25.0 darwin/arm64, confirming the hermetic SDK actually moved rather than the pin merely being edited.✅
make build— 309 targets.✅
make test— 98/98 pass.✅
make tidy/make gazelle/make fmt— clean, no generated-file drift.Not run locally: the Docker-based integration and e2e suites, which is where the cross-compiled linux SDK and the rebuilt debug image are first exercised end to end. Those run in CI — worth watching them here specifically rather than treating this as a no-op diff.