Skip to content

feat(stovepipe): Promote green commits to a ref - #580

Merged
prathshenoy merged 1 commit into
mainfrom
prath.shenoy/promote
Aug 13, 2026
Merged

feat(stovepipe): Promote green commits to a ref#580
prathshenoy merged 1 commit into
mainfrom
prath.shenoy/promote

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

What:

  • When a validation establishes a commit as green, the record stage now asks source control to advance the queue's promotion ref to that commit, so downstream systems can fetch the latest known-good commit by branch name. Which ref a queue promotes to, and whether it promotes at all, is source-control configuration resolved from the queue name.
  • Promotion happens only while the request still holds the queue's last-green bookmark, and a commit that a rewritten history dropped from the branch is counted and skipped rather than retried.

Why:

  • Consumers that only need "where is this branch last green" had to query Stovepipe and understand requests, commit locators and greenness degrees; resolving a branch name lets a consumer get the same answer with a plain fetch.
  • Reusing the bookmark's existing ordering guard keeps the ref forward-only without new state, and skipping commits that left the branch avoids dead-lettering work whose greenness is already durable.

Test Plan

  • Add unit tests.

Revert Plan

  • Revert this PR. The only residue is the ref sitting at whatever commit it last landed on.

Issues

@prathshenoy
prathshenoy force-pushed the prath.shenoy/promote branch from b3d6d47 to 01d465e Compare August 12, 2026 14:39
@prathshenoy
prathshenoy marked this pull request as ready for review August 12, 2026 14:41
@prathshenoy
prathshenoy enabled auto-merge August 12, 2026 14:45
@prathshenoy
prathshenoy added this pull request to the merge queue Aug 12, 2026
@behinddwalls
behinddwalls removed this pull request from the merge queue due to a manual request Aug 12, 2026

@mnoah1 mnoah1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - before merging, go ahead and implement the Promote endpoint on our internal source control extension, so the version bump job succeeds.

@prathshenoy
prathshenoy force-pushed the prath.shenoy/promote branch from 01d465e to ca245f5 Compare August 13, 2026 02:15
@prathshenoy
prathshenoy enabled auto-merge August 13, 2026 02:17
@prathshenoy
prathshenoy added this pull request to the merge queue Aug 13, 2026
Merged via the queue into main with commit 7a2a478 Aug 13, 2026
15 checks passed
@prathshenoy
prathshenoy deployed to stack-rebase August 13, 2026 02:20 — with GitHub Actions Active
@behinddwalls
behinddwalls deleted the prath.shenoy/promote branch August 13, 2026 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants