4174 only read indats using the indat class - #4523
Draft
clmould wants to merge 8 commits into
Draft
Conversation
2 tasks
clmould
force-pushed
the
4174-only-read-indats-using-the-indat-class
branch
from
August 13, 2026 16:26
bc34539 to
eda15dc
Compare
2 tasks
…), and got it working to update the obsolete vars when running process, includes pdbs
… in test need to call InDat in init_process in order to update obs vars
clmould
force-pushed
the
4174-only-read-indats-using-the-indat-class
branch
from
August 20, 2026 13:15
eda15dc to
0b82c25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The functionality from:
validate_input()parse_input_file()validate_variable()should be contained in the
InDatclass, instead of reading in IN.DATs and parsing the variables in multiple locations.InDatmethods should be tidied up and combined where appropriateChecklist
I confirm that I have completed the following checks: