Skip to content

Add eich jet asdex sol scalings - #4543

Open
chris-ashe wants to merge 6 commits into
mainfrom
add_eich_jet_asdex_sol_scalings
Open

Add eich jet asdex sol scalings#4543
chris-ashe wants to merge 6 commits into
mainfrom
add_eich_jet_asdex_sol_scalings

Conversation

@chris-ashe

Copy link
Copy Markdown
Collaborator

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe
chris-ashe requested a review from a team as a code owner August 18, 2026 10:12
@chris-ashe chris-ashe added the Scrape off Layer Relating to the scrape off layer outside the plasma separatrix label Aug 18, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.42%. Comparing base (e9c8593) to head (1ce1096).

Files with missing lines Patch % Lines
process/models/physics/scrape_off_layer.py 42.85% 8 Missing ⚠️
process/core/io/plot/summary.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4543   +/-   ##
=======================================
  Coverage   49.42%   49.42%           
=======================================
  Files         150      150           
  Lines       29861    29883   +22     
=======================================
+ Hits        14759    14771   +12     
- Misses      15102    15112   +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@je-cook
je-cook requested a review from a team August 18, 2026 12:48

@je-cook je-cook left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍, regression failures because of new outputs

@je-cook
je-cook requested a review from a team August 18, 2026 12:50
@je-cook je-cook self-assigned this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scrape off Layer Relating to the scrape off layer outside the plasma separatrix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants