Skip to content

fix(plugins): cfg-gate non-Windows hook path import - #3302

Open
dajiaohuang wants to merge 1 commit into
ultraworkers:mainfrom
dajiaohuang:fix/windows-clippy-hooks-import
Open

dajiaohuang wants to merge 1 commit into
ultraworkers:mainfrom
dajiaohuang:fix/windows-clippy-hooks-import

Conversation

@dajiaohuang

Copy link
Copy Markdown

Summary

  • Gate the non-Windows-only Path import in the plugin hook runner.
  • Keep non-Windows behavior unchanged while allowing Windows strict clippy to compile the plugins crate.

Anti-slop triage

  • Classification: actionable-fix
  • Evidence: Windows cargo clippy --workspace --all-targets -- -D warnings reported
    ust/crates/plugins/src/hooks.rs:2 as an unused import; the targeted plugins clippy check passes after this change.
  • Non-destructive review result: merge candidate

Verification

  • cargo fmt --all --check
  • cargo check -p plugins
  • cargo clippy -p plugins --all-targets -- -D warnings
  • git diff --check
  • No secrets, tokens, private logs, or unrelated generated files are included.
  • Full workspace test/clippy runs remain blocked by existing Windows-incompatible Unix-only tests and unrelated pre-existing diagnostics outside this one-line fix.

Resolution gate

  • Standalone cross-platform lint fix; no issue link is required.
  • I did not merge or close remote PRs or issues.

@1716775457damn

Copy link
Copy Markdown

Thanks for the fix. On Windows the unused Path import indeed trips cargo clippy -D warnings, so cfg-gating it is the right call. Non-Windows behavior stays untouched and the targeted clippy check passing confirms it.

@1716775457damn

Copy link
Copy Markdown

修复方向正确。建议在 Windows CI 工作流中补上 cargo clippy -p plugins --all-targets -- -D warnings,避免这类 Unix-only import 问题将来回归。

@dajiaohuang

Copy link
Copy Markdown
Author

Thanks — the targeted Windows clippy check passes for this change. Adding a new Windows CI workflow is broader than the import fix and would need maintainer direction, so I left CI unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants