feat: Add time-of-day filtering with quick hour filters and time range picker#3978
feat: Add time-of-day filtering with quick hour filters and time range picker#3978Yashh56 wants to merge 9 commits intoumami-software:devfrom
Conversation
|
@Yashh56 is attempting to deploy a commit to the umami-software Team on Vercel. A member of the Team first needs to authorize it. |
Greptile SummaryThis PR enhances the The previously flagged issues (duplicate
Confidence Score: 4/5Safe to merge once the missing locale translation strings are added; all previously flagged runtime errors are resolved. All major prior issues (formatMessage crash, duplicate labels declaration, uninitialized state) are fixed. The one remaining P1 is missing translation entries in locale files — the new UI elements will render raw key strings (e.g. "label.time-range") for every user until the strings are added. public/intl/messages/en-US.json (and other locale files) need the three new translation keys added. Important Files Changed
Reviews (5): Last reviewed commit: "Use translation function for time range ..." | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…w time range labels
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
Hey @mikecao , can you please have a look at this? |
This pull request adds enhanced time-based filtering options to the
DateFiltercomponent, allowing users to select more granular time ranges, including specific hours within a day. It introduces a newTimeRangePickerFormcomponent, updates the available filter options, and adds supporting labels for improved user experience.New time range filtering features:
TimeRangePickerFormcomponent that allows users to select a specific date and start/end hours, enabling hour-level granularity for date filters. (src/components/metrics/TimeRangePickerForm.tsx)DateFiltercomponent to include new quick-select options for the last 1, 2, 4, 6, and 12 hours, and added a "Time range" option that opens the new time picker modal. (src/components/input/DateFilter.tsx) [1] [2]DateFiltercomponent, handling its open/close state and passing selected values back to the parent. (src/components/input/DateFilter.tsx) [1] [2] [3] [4]Internationalization and UI improvements:
src/components/messages.ts)TimeRangePickerFormin theDateFiltercomponent to enable the modal functionality. (src/components/input/DateFilter.tsx)Closes #3962