fix: increase website selector dropdown limit from 10 to 100#4129
fix: increase website selector dropdown limit from 10 to 100#4129gputier wants to merge 1 commit intoumami-software:masterfrom
Conversation
The WebsiteSelect component had a hardcoded pageSize of 10, which meant users with more than 10 websites could not see all of them in the dropdown. The list container already has maxHeight: 400px with scroll, so a higher limit doesn't affect the UI. Fixes umami-software#4128
|
@gputier is attempting to deploy a commit to the Umami Software Team on Vercel. A member of the Team first needs to authorize it. |
Greptile SummaryThis PR bumps the Confidence Score: 5/5Safe to merge — isolated one-line change with no logic impact, no backend constraint violated. The only change is a numeric literal bump (10 → 100) in a query param. The backend schema imposes no max on pageSize, the UI already scrolls, and no edge cases are introduced. All remaining considerations are P2 at most. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant U as User
participant WS as WebsiteSelect
participant API as /me/websites (or /users/:id/websites)
participant DB as Database
U->>WS: Open dropdown
WS->>API: GET ?pageSize=100&search=...
API->>DB: SELECT websites LIMIT 100
DB-->>API: up to 100 rows
API-->>WS: { data: [...], count: N }
WS-->>U: Render up to 100 sites in scrollable list
U->>WS: Type in search box
WS->>API: GET ?pageSize=100&search=typed
API->>DB: SELECT websites WHERE name LIKE '%typed%' LIMIT 100
DB-->>API: filtered rows
API-->>WS: { data: [...], count: M }
WS-->>U: Render filtered results
Reviews (1): Last reviewed commit: "fix: increase website selector dropdown ..." | Re-trigger Greptile |
Closes #4128
Related: #3913
The
WebsiteSelectcomponent has a hardcodedpageSize: 10, which hides websites beyond the first 10 from the dropdown. Users with 11+ sites can only reach the missing ones through the search field — assuming they know it's there.#3913 was marked "fixed in dev" with the limit bumped to 20, but on
master(and v3.0.3) it's still 10. This PR bumps it to 100. The dropdown list already hasmaxHeight: 400pxwith overflow scroll, so the UI handles larger lists fine.One-line change in
src/components/input/WebsiteSelect.tsx.