Skip to content

fix: increase website selector dropdown limit from 10 to 100#4129

Open
gputier wants to merge 1 commit intoumami-software:masterfrom
gputier:fix/website-select-page-size
Open

fix: increase website selector dropdown limit from 10 to 100#4129
gputier wants to merge 1 commit intoumami-software:masterfrom
gputier:fix/website-select-page-size

Conversation

@gputier
Copy link
Copy Markdown

@gputier gputier commented Apr 2, 2026

Closes #4128
Related: #3913

The WebsiteSelect component has a hardcoded pageSize: 10, which hides websites beyond the first 10 from the dropdown. Users with 11+ sites can only reach the missing ones through the search field — assuming they know it's there.

#3913 was marked "fixed in dev" with the limit bumped to 20, but on master (and v3.0.3) it's still 10. This PR bumps it to 100. The dropdown list already has maxHeight: 400px with overflow scroll, so the UI handles larger lists fine.

One-line change in src/components/input/WebsiteSelect.tsx.

The WebsiteSelect component had a hardcoded pageSize of 10, which meant
users with more than 10 websites could not see all of them in the
dropdown. The list container already has maxHeight: 400px with scroll,
so a higher limit doesn't affect the UI.

Fixes umami-software#4128
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 2, 2026

@gputier is attempting to deploy a commit to the Umami Software Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 2, 2026

Greptile Summary

This PR bumps the pageSize parameter in WebsiteSelect from 10 to 100, fixing a UX issue where users with more than 10 websites could not see all sites in the dropdown without knowing to use the search field. The backend pagingParams schema accepts any positive integer for pageSize, and the existing maxHeight: 400px scroll container in the dropdown handles the larger list gracefully. Users with more than 100 websites will still need the search field, but this is a reasonable practical limit for the vast majority of users.

Confidence Score: 5/5

Safe to merge — isolated one-line change with no logic impact, no backend constraint violated.

The only change is a numeric literal bump (10 → 100) in a query param. The backend schema imposes no max on pageSize, the UI already scrolls, and no edge cases are introduced. All remaining considerations are P2 at most.

No files require special attention.

Important Files Changed

Filename Overview
src/components/input/WebsiteSelect.tsx Single-line change: bumps pageSize from 10 to 100 in the useUserWebsitesQuery call; no logic changes, backend schema imposes no upper bound on pageSize

Sequence Diagram

sequenceDiagram
    participant U as User
    participant WS as WebsiteSelect
    participant API as /me/websites (or /users/:id/websites)
    participant DB as Database

    U->>WS: Open dropdown
    WS->>API: GET ?pageSize=100&search=...
    API->>DB: SELECT websites LIMIT 100
    DB-->>API: up to 100 rows
    API-->>WS: { data: [...], count: N }
    WS-->>U: Render up to 100 sites in scrollable list
    U->>WS: Type in search box
    WS->>API: GET ?pageSize=100&search=typed
    API->>DB: SELECT websites WHERE name LIKE '%typed%' LIMIT 100
    DB-->>API: filtered rows
    API-->>WS: { data: [...], count: M }
    WS-->>U: Render filtered results
Loading

Reviews (1): Last reviewed commit: "fix: increase website selector dropdown ..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Website selector dropdown only shows 10 sites

1 participant