fix: Prevent Recursive Call in Update module.go#4778
Open
moshderte wants to merge 1 commit intounionlabs:mainfrom
Open
fix: Prevent Recursive Call in Update module.go#4778moshderte wants to merge 1 commit intounionlabs:mainfrom
moshderte wants to merge 1 commit intounionlabs:mainfrom
Conversation
Summary
This PR fixes a recursive call bug in the RegisterInterfaces method of the AppModuleBasic struct.
What was the issue?
Previously, the method was defined as: func (AppModuleBasic) RegisterInterfaces(registry codectypes.InterfaceRegistry) {
RegisterInterfaces(registry)
This leads to an infinite recursive call, as the method was calling itself instead of the intended package-level RegisterInterfaces function. This results in a stack overflow panic at runtime.
What was changed?
Renamed the package-level RegisterInterfaces function to RegisterCometBLSInterfaces and updated the method accordingly: func (AppModuleBasic) RegisterInterfaces(registry codectypes.InterfaceRegistry) {
RegisterCometBLSInterfaces(registry)
Why is this important?
Prevents runtime panic due to infinite recursion
Makes the code more maintainable and less prone to name shadowing errors
|
@moshderte is attempting to deploy a commit to the unionbuild Team on Vercel. A member of the Team first needs to authorize it. |
|
Fixed |
Author
|
@aeryz check please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a recursive call bug in the RegisterInterfaces method of the AppModuleBasic struct.
What was the issue?
Previously, the method was defined as: func (AppModuleBasic) RegisterInterfaces(registry codectypes.InterfaceRegistry) {
RegisterInterfaces(registry)
This leads to an infinite recursive call, as the method was calling itself instead of the intended package-level RegisterInterfaces function. This results in a stack overflow panic at runtime.
What was changed?
Renamed the package-level RegisterInterfaces function to RegisterCometBLSInterfaces and updated the method accordingly: func (AppModuleBasic) RegisterInterfaces(registry codectypes.InterfaceRegistry) {
RegisterCometBLSInterfaces(registry)
Why is this important?
Prevents runtime panic due to infinite recursion
Makes the code more maintainable and less prone to name shadowing errors