Repository navigation
Conversation
Co-authored-by: pchiusano <11074+pchiusano@users.noreply.github.com>
Co-authored-by: pchiusano <11074+pchiusano@users.noreply.github.com>
Co-authored-by: pchiusano <11074+pchiusano@users.noreply.github.com>
Co-authored-by: pchiusano <11074+pchiusano@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pchiusano @ChrisPenner
Overview
Replace opaque
empty Foldcrashes from invalid local definition references with diagnostics that identify the reference kind, index, lookup size, and term/type/component context. Validate persisted mapping indices and imported term references so inconsistent data is caught closer to its source.Implementation notes
Interesting/controversial decisions
Validation failures include IDs and hash/component context, but do not include term contents.
Test coverage
Added focused local-reference unit tests.
stack test share-api:local-reference-testscould not run because Stack could not find the Unison submodule package atunison/codebase2/codebase/in this environment.Loose ends
Initialize the Unison submodule and rerun the test target.