Skip to content

fix(hooks): prevent panic from loop variable capture in concurrent execution #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmainas merged 1 commit into from
Feb 12, 2026
Merged

fix(hooks): prevent panic from loop variable capture in concurrent execution #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/contributors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ users:
ishaanxgupta:
name: Ishaan Gupta
email: ishaankone@gmail.com
hemang1404:
name: Hemang Sharrma
email: hemangsharrma@gmail.com
ilp-sys:
name: Jiwoo Ahn
email: ikwydls1314@gmail.com
Expand Down
4 changes: 2 additions & 2 deletions pkg/unikontainers/unikontainers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,8 +777,8 @@ func (u *Unikontainer) executeHooksConcurrently(name string, hooks []specs.Hook,
uniklog.WithFields(logrus.Fields{
"id": u.State.ID,
"name": name,
"path": hooks[i].Path,
"args": hooks[i].Args,
"path": h.Path,
"args": h.Args,
"error": err,
}).Error("Executing hook failed")
errChan <- err
Expand Down
Loading