Skip to content

feat/rascal formatter - #1102

Draft
jurgenvinju wants to merge 70 commits into
mainfrom
feat/rascal-formatter
Draft

feat/rascal formatter#1102
jurgenvinju wants to merge 70 commits into
mainfrom
feat/rascal-formatter

Conversation

@jurgenvinju

@jurgenvinju jurgenvinju commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This is for @toinehartman and myself to experiment with the Rascal formatter in VScode.

This is a draft and may never be merged directly into main.

  • links the Rascal formatter from the stdlib to the format capability in LSP
  • will not fully map all FormattingOptions, since that is already done here: Parametric: formatting #677
  • this PR is intended to merge with Parametric: formatting #677 such that we don't duplicate code or effort writing it.
  • support for formatting only a selection via the Focus mechanism
    • may require some additions to subTreeEdits in util::Formatters from the stdlib to learn the outermost indentation from the context.

@toinehartman
Rascal LSP formatting API and example.
630ccc4
@toinehartman
Provide overridable defaults for common string operations.
d3675c4
@toinehartman
Align names with DocumentFormattingParams
b32d2f6
@toinehartman
Implement parametric formatting.
f16e17a
@toinehartman
Ongoing design work.
b749dcf
@toinehartman
Experiment with a first formatting implementation using Box.
f1effe1
@toinehartman
Simplify API and shift responsibilities towards DSL.
6fc3acf
@toinehartman
Improve names in formatting library.
bdb7989
@toinehartman
Add indentation conversion functions.
a985a81
@toinehartman
Do string modifications in Pico formatter.
0196d07
@toinehartman
Update formatting API design.
d1c4e3e
@toinehartman
Add mergeLines
49b66d0
@toinehartman
Small fixes.
998a115
@toinehartman
Break new line ties by order.
551fe2a
@toinehartman
Document & fix string/formatting utils.
84c5a35
@toinehartman
Add rangeFormatting, reuse formatting.
c4b3561
@toinehartman
Match contribution sig in implementation.
1748678
@toinehartman
Add missing license header.
1d56010
@toinehartman
Document formatting service.
20a71ae
@toinehartman
Use formatter from stdlib.
cda1531
@toinehartman
Change defaults based on discussion with @DavyLandman.
206a57a
@toinehartman
Fix import to renamed module.
6cdab51
@toinehartman
Format Pico examples.
05b2955
@toinehartman
Inline function.
9561883
@toinehartman
Use focus instead of Tree+loc.
7b92033
@toinehartman
Implement range focus with special case for lists.
244da24
@toinehartman
Fix comment about Rascal charcter encoding.
69307a7
@toinehartman
Add basic TreeSearch tests.
c1b08a8
@toinehartman
Consider layout as well.
6f5657f
@toinehartman
Include partially selected element at end of range.
49cf9be
jurgenvinju and others added 28 commits June 8, 2026 10:54
@jurgenvinju
pico formatter refactored
c4201ce
@jurgenvinju
missing import added
3dd69f6
@toinehartman
Add missing header.
68c11a1
@toinehartman
Remove formatting util & fix references.
df55b71
@toinehartman
Test DSL formatting.
3b53f00
@jurgenvinju
late fixes
01b5f2e
@jurgenvinju
fixes from other branch
578618a
@jurgenvinju
search excludes
1b6ae22
@jurgenvinju
set executable bit
7d3101a
@jurgenvinju
resolved issue with final layout for substring formatters
c58b7cf
@jurgenvinju
clean up module and removed dead code and debug code
51932cb
@jurgenvinju
set version number right
b4bb6e9
@jurgenvinju
working version
71c963e
@jurgenvinju
Merge remote-tracking branch 'origin/feat/rascal-formatter' into feat…
d1db887 
…ure/lsp-formatting
@jurgenvinju
factored FormattingOptions converter for reuse by rascal and lsp server
9b47c0f
@jurgenvinju
factored and reused formatting options converter
a5f18cb
@jurgenvinju
fixed ambiguous overload for formatter function of Pico
d8fc8eb
@jurgenvinju
Merge branch 'main' into feature/lsp-formatting
07f0e65 
This was a detailed manual merge
@jurgenvinju
fixed a broken merge
9da8b7e
@jurgenvinju
fix missing code
a9b83a6
@jurgenvinju
removed sleep from import
0bc051b
@jurgenvinju
revert chai to version 4 because then it still supported plain js mod…
c7221bb 
…ules.
@jurgenvinju
added missing header
baba15b
@jurgenvinju
Merge branch 'main' into feat/rascal-formatter
75cedf0
@jurgenvinju
Merge remote-tracking branch 'origin/feature/lsp-formatting' into fea…
d50db56 
…t/rascal-formatter
@jurgenvinju
temporarily removed the parametric formatter service implementations …
24dfd0a 
…and API and tests
@jurgenvinju
reset chai to version 6
cf02589
@jurgenvinju
temporarily removed the parametric formatter service implementations …
59a19b2 
…and API and tests
@sonarqubecloud

sonarqubecloud Bot commented Aug 28, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
56.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@toinehartman toinehartman mentioned this pull request Aug 28, 2026
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toinehartman toinehartman Awaiting requested review from toinehartman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jurgenvinju @toinehartman