syntax role modifiers by jurgenvinju · Pull Request #1835 · usethesource/rascal

jurgenvinju · 2023-07-07T08:02:22Z

This PR implements syntax role modifiers.

codecov · 2023-07-07T08:06:47Z

Codecov Report

❌ Patch coverage is 9.27673% with 577 lines in your changes missing coverage. Please review.
✅ Project coverage is 45%. Comparing base (4f96714) to head (fc82a86).
⚠️ Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
src/org/rascalmpl/types/ModifySyntaxRole.java	0%	309 Missing ⚠️
src/org/rascalmpl/ast/SyntaxRoleModifier.java	0%	114 Missing ⚠️
...ascalmpl/semantics/dynamic/SyntaxRoleModifier.java	0%	27 Missing ⚠️
src/org/rascalmpl/ast/Type.java	21%	25 Missing ⚠️
src/org/rascalmpl/library/Type.java	33%	24 Missing ⚠️
src/org/rascalmpl/types/RascalTypeFactory.java	4%	21 Missing and 1 partial ⚠️
...org/rascalmpl/values/parsetrees/SymbolFactory.java	5%	16 Missing ⚠️
src/org/rascalmpl/ast/NullASTVisitor.java	0%	6 Missing ⚠️
...almpl/interpreter/staticErrors/UnexpectedType.java	25%	4 Missing and 2 partials ⚠️
src/org/rascalmpl/types/RascalType.java	0%	6 Missing ⚠️
... and 9 more

Additional details and impacted files

@@           Coverage Diff            @@
##              main   #1835    +/-   ##
========================================
- Coverage       45%     45%    -1%     
- Complexity    6801    6819    +18     
========================================
  Files          844     848     +4     
  Lines        68785   69424   +639     
  Branches     10023   10136   +113     
========================================
+ Hits         31344   31469   +125     
- Misses       35066   35575   +509     
- Partials      2375    2380     +5

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…n type symbols

…odifiers

…modifiers

…and ParseTree

…d dead commented code

…avoid complex manual merge

…ole is different

… uses the new syntax for role modifiers too soon

sonarqubecloud · 2026-04-10T18:15:28Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2026-06-26T12:03:05Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Had to regenerate the parser

jurgenvinju · 2026-08-31T15:17:13Z

+	| modifier: SyntaxRoleModifier modifier
+	;
+
+syntax SyntaxRoleModifier // TODO @rodin zegt dat dit Type moet zijn en niet TypeArg


Opletten hier

jurgenvinju · 2026-08-31T15:21:20Z

        }
    }

-    private static void $usage(String module, String error, Type kwargs) {


Is this relevant?

jurgenvinju

This PR is almost done. Needs some cleaning of unrelated changes and attention to new TODO comments.

sonarqubecloud · 2026-08-31T15:31:24Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

added syntax role modifier syntax

9176f03

regenerated parser with new syntax role modifier syntax

ecde46c

jurgenvinju mentioned this pull request Jul 17, 2023

Type.match and Type.instantiate for NonTerminalType #1844

Open

jurgenvinju mentioned this pull request Aug 15, 2023

parse(#Exp, "2+3") example doesn't work #1423

Closed

jurgenvinju added 14 commits September 26, 2023 14:27

Merge branch 'main' into syntax-role-modifiers

0cd1be5

regenerated parser and AST hierarchy to include SyntaxRoleModifiers i…

82e4422

…n type symbols

working on syntax roles

14fcf36

Merge branch 'main' into syntax-role-modifiers

e2a0148

Merge branch 'main' into syntax-role-modifiers

bf1f3d5

added Symbol-level syntax and semantics of syntax role modifiers

0c63da9

added bootstrap declarations for Symbols that represent syntax role m…

1c56ba5

…odifiers

implemented isOpen and IsParametrized for syntax types

29fbfa3

fixed copy and paste bug

878275e

partially implemented java-level syntax and semantics of syntax role …

0627a87

…modifiers

implementing all the Type operations on Syntax modifiers

3e92b42

implemented lub on syntax modifiers

bdb8f0b

implemented Type.glbWithModifySyntax and added subtype cases to Type …

2036232

…and ParseTree

fixed compiler error and removed unused imports

95f8a97

jurgenvinju added the enhancement label Nov 16, 2023

jurgenvinju requested review from DavyLandman and rodinaarssen November 16, 2023 16:16

jurgenvinju added 8 commits November 17, 2023 10:14

added match and instantiate for SyntaxRole modifier types, and remove…

699219f

…d dead commented code

added assert

b3c14e0

match data[&T] against Tree if &T is a non-terminal

6bd6cc8

fixing corner cases

9136580

fixed subtle bug in applying syntax role

3973aa2

added some initial tests for syntax modifiers

86be7a5

added a failing test for data[&T] matching against parse tree

0d49956

typo

5abbbe7

jurgenvinju added 10 commits July 9, 2025 16:52

Merge branch 'main' into syntax-role-modifiers

e3f4071

regenerated parser and asts for Rascal with syntax role modifiers to …

e665154

…avoid complex manual merge

Merge branch 'main' into syntax-role-modifiers

58bec27

regenerated parser and AST hierarchy

6d11cf8

added source location and name of function that was hard to link

b1b2135

removed unused functions that ended up cloned in AType.rsc

47095db

explain some unexpected types better if the names are equal but the r…

a87d6ae

…ole is different

fixed comments

16de49d

Hide Explode.rsc file from previous version of the checker because it…

b9da6c2

… uses the new syntax for role modifiers too soon

Hide SyntaxRoleModifiers1.rsc for bootstrapping purposes

55b2a34

DavyLandman force-pushed the main branch from c145f56 to 945817e Compare June 26, 2026 08:54

DavyLandman force-pushed the syntax-role-modifiers branch 2 times, most recently from 4b3b7e6 to 55b2a34 Compare June 26, 2026 12:02

jurgenvinju added 2 commits August 31, 2026 12:24

Merge branch 'main' into syntax-role-modifiers

e9ec9ba

Had to regenerate the parser

regenerated with more modern generator

88b8e1a