Update all cache statuses

[fogelito]

Summary by CodeRabbit

• Bug Fixes
  • Improved resource caching during migration operations for ROW and DOCUMENT resources. Enhanced handling ensures more consistent and reliable behavior throughout the migration process.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The change modifies special handling for ROW/DOCUMENT resources in the Cache::update method. Previously, the code computed the resource status and only added the resource to cache when the status was not STATUS_SUCCESS. The updated logic removes this status check and unconditionally calls add($resource) for ROW/DOCUMENT resources before returning, simplifying the control flow.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Behavioral logic change: The removal of the status check condition fundamentally alters when resources are cached, requiring verification that this change is intentional and safe
• Caching implications: Review should confirm why unconditional caching is now appropriate and whether this affects downstream processing of ROW/DOCUMENT resources
• Single method scope: Limited code surface area helps keep review effort moderate rather than high

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Update all cache statuses' is vague and does not clearly convey the specific change: simplifying special handling for ROW/DOCUMENT resources in Cache::update by removing status checks.	Use a more specific title that describes the actual change, such as 'Simplify ROW/DOCUMENT resource cache handling by removing status check' or 'Always add ROW/DOCUMENT resources to cache without status verification'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch disable-documents-cache

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f7b4823 and e5f1cf7.

📒 Files selected for processing (1)

• src/Migration/Cache.php (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-06-28T09:47:58.757Z

Learnt from: ItzNotABug
Repo: utopia-php/migration PR: 80
File: src/Migration/Sources/Supabase.php:300-308
Timestamp: 2025-06-28T09:47:58.757Z
Learning: In the utopia-php/migration codebase, during the terminology swap from Collection/Attribute/Document to Table/Column/Row, the user ItzNotABug prefers to keep the existing query logic unchanged even if it becomes semantically incorrect with the new naming. The focus is purely on resource type renaming, not on fixing logical issues that become apparent after the terminology change.

Applied to files:

• src/Migration/Cache.php

🔇 Additional comments (1)

src/Migration/Cache.php (1)

139-143: Confirm this behavioral change aligns with downstream cache consumers.

This change unconditionally adds all ROW/DOCUMENT resources to the status counters, including those with STATUS_SUCCESS. Previously, only non-SUCCESS statuses were counted. While the PR title "Update all cache statuses" suggests this is intentional, ensure that code reading these counters—particularly any logic that calculates progress, reports failures, or checks isSuccess()—correctly handles SUCCESS statuses now being included in the cache.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}